From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 01/13] ARM: shmobile: r8a7792: add clock index macros
Date: Wed, 1 Jun 2016 16:57:40 +0300 [thread overview]
Message-ID: <81cc10bc-47bb-87b8-57e9-84b2cce92b1e@cogentembedded.com> (raw)
In-Reply-To: <20160601005246.GF20527@verge.net.au>
On 06/01/2016 03:52 AM, Simon Horman wrote:
>> Add macros usable by the device tree sources to reference the R8A7792
>> clocks by index.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> include/dt-bindings/clock/r8a7792-clock.h | 104 ++++++++++++++++++++++++++++++
>> 1 file changed, 104 insertions(+)
>>
>> Index: renesas/include/dt-bindings/clock/r8a7792-clock.h
>> ===================================================================
>> --- /dev/null
>> +++ renesas/include/dt-bindings/clock/r8a7792-clock.h
>> @@ -0,0 +1,104 @@
>> +/*
>> + * Copyright (C) 2016 Cogent Embedded, Inc.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + */
>> +
>> +#ifndef __DT_BINDINGS_CLOCK_R8A7792_H__
>> +#define __DT_BINDINGS_CLOCK_R8A7792_H__
>> +
>> +/* CPG */
>> +#define R8A7792_CLK_MAIN 0
>> +#define R8A7792_CLK_PLL0 1
>> +#define R8A7792_CLK_PLL1 2
>> +#define R8A7792_CLK_PLL3 3
>> +#define R8A7792_CLK_LB 4
>> +#define R8A7792_CLK_QSPI 5
>> +#define R8A7792_CLK_SDH 6
>> +#define R8A7792_CLK_SD0 7
>> +#define R8A7792_CLK_SD1 8
>> +#define R8A7792_CLK_Z 9
>
> According to my copy of the documentation (v2.00) SDH, SD0 and SD1 do
> not seem to be provided by the r8a7792 CPG.
Right, should have checked the original patch against the manual in that
part as well... :-/
> It does, however, provide RCAN and ADSP which are supported by the CPG
> driver. You may wish to add them now for completeness though from my point
> of view they could also be added later when they are used.
Hm, the gen2 manual rev1.02 doesn't mention either of these clocks for V2H...
I still don't have 2.00. :-(
> I reviewed the values below. They appear to be complete and correct.
Geert has found some bug there. :-)
MBR, Sergei
next prev parent reply other threads:[~2016-06-01 13:57 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 22:06 [PATCH 00/13] Add R8A7794/SILK board eMMC DT support Sergei Shtylyov
2016-05-31 22:09 ` [PATCH 01/13] ARM: shmobile: r8a7792: add clock index macros Sergei Shtylyov
2016-06-01 0:52 ` Simon Horman
2016-06-01 13:57 ` Sergei Shtylyov [this message]
2016-06-22 19:52 ` Sergei Shtylyov
2016-06-22 22:33 ` Simon Horman
[not found] ` <20160622223330.GA15843-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2016-06-23 7:46 ` Geert Uytterhoeven
2016-06-23 10:49 ` Sergei Shtylyov
[not found] ` <2280165.siMXMbFrFe-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 7:22 ` Geert Uytterhoeven
2016-06-01 14:09 ` Sergei Shtylyov
2016-05-31 22:11 ` [PATCH 02/13] ARM: shmobile: r8a7792: add power domain " Sergei Shtylyov
2016-06-01 7:32 ` Geert Uytterhoeven
2016-05-31 22:20 ` [PATCH 05/13] DT: clock: rcar-gen2-cpg-clocks: document R8A7792 support Sergei Shtylyov
2016-06-01 0:25 ` Simon Horman
2016-06-01 0:30 ` Simon Horman
2016-06-01 7:50 ` Geert Uytterhoeven
2016-06-01 7:48 ` Geert Uytterhoeven
2016-06-03 1:49 ` Rob Herring
2016-05-31 22:21 ` [PATCH 06/13] DT: clock: cpg-mstp-clocks: document-R8A7792-support Sergei Shtylyov
2016-06-01 0:28 ` Simon Horman
2016-06-01 7:51 ` Geert Uytterhoeven
2016-06-03 1:50 ` Rob Herring
2016-05-31 22:24 ` [PATCH 07/13] ARM: dts: r8a7792: initial SoC device tree Sergei Shtylyov
2016-06-01 0:57 ` Simon Horman
2016-06-01 14:00 ` Sergei Shtylyov
2016-06-06 22:26 ` Sergei Shtylyov
2016-06-07 7:13 ` Geert Uytterhoeven
2016-06-07 20:58 ` Sergei Shtylyov
2016-06-10 1:02 ` Simon Horman
2016-06-10 19:29 ` Sergei Shtylyov
2016-06-10 20:42 ` Geert Uytterhoeven
2016-06-10 20:50 ` Sergei Shtylyov
2016-06-13 7:12 ` Geert Uytterhoeven
2016-06-13 11:24 ` Sergei Shtylyov
[not found] ` <7d93d81d-cca9-e434-6488-0ea839f81663-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-13 11:48 ` Geert Uytterhoeven
2016-06-14 1:08 ` Kuninori Morimoto
2016-06-17 2:14 ` Kuninori Morimoto
2016-06-17 6:27 ` Geert Uytterhoeven
[not found] ` <8efb1c7e-5463-2556-744c-d327886d92d4-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-14 0:43 ` Simon Horman
2016-06-14 21:08 ` Sergei Shtylyov
2016-06-16 0:06 ` Simon Horman
2016-06-01 9:23 ` Geert Uytterhoeven
2016-05-31 22:25 ` [PATCH 08/13] ARM: dts: r8a7792: add SYS-DMAC support Sergei Shtylyov
2016-06-01 1:03 ` Simon Horman
[not found] ` <5621267.GpvUaW18zI-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 8:15 ` Geert Uytterhoeven
2016-05-31 22:26 ` [PATCH 09/13] ARM: dts: r8a7792: add [H]SCIF support Sergei Shtylyov
2016-06-01 1:13 ` Simon Horman
2016-06-03 14:33 ` Sergei Shtylyov
2016-06-01 8:17 ` Geert Uytterhoeven
2016-05-31 22:29 ` [PATCH 10/13] ARM: dts: r8a7792: add IRQC support Sergei Shtylyov
2016-06-01 1:18 ` Simon Horman
2016-06-01 14:02 ` Sergei Shtylyov
[not found] ` <3573091.BUvyGW3hVt-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 8:17 ` Geert Uytterhoeven
2016-05-31 22:30 ` [PATCH 11/13] DT: arm: shmobile: document Blanche board Sergei Shtylyov
2016-05-31 23:51 ` Simon Horman
[not found] ` <20160531235119.GA20527-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2016-06-01 13:34 ` Sergei Shtylyov
2016-06-01 8:19 ` Geert Uytterhoeven
2016-06-03 1:50 ` Rob Herring
2016-05-31 22:32 ` [PATCH 12/13] ARM: dts: blanche: initial device tree Sergei Shtylyov
2016-06-01 1:21 ` Simon Horman
2016-06-02 21:34 ` Sergei Shtylyov
2016-06-01 8:36 ` Geert Uytterhoeven
2016-05-31 22:33 ` [PATCH 13/13] ARM: dts: blanche: add Ethernet support Sergei Shtylyov
2016-06-01 1:24 ` Simon Horman
[not found] ` <1669958.qjJ7i3NBPv-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 8:22 ` Geert Uytterhoeven
2016-06-01 12:16 ` Sergei Shtylyov
[not found] ` <a60346f2-2abb-342b-dd20-38d401c4ceb3-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-06-01 12:27 ` Geert Uytterhoeven
2016-06-02 21:33 ` Sergei Shtylyov
[not found] ` <13205049.n7pM8utpHF-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2016-06-01 7:04 ` [PATCH 00/13] Add R8A7794/SILK board eMMC DT support Geert Uytterhoeven
2016-06-01 10:30 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81cc10bc-47bb-87b8-57e9-84b2cce92b1e@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).