From: "Guido Günther" <agx@sigxcpu.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 6/6] leds: lm3692x: Make sure we don't exceed the maximum led current
Date: Wed, 25 Dec 2019 12:07:19 +0100 [thread overview]
Message-ID: <96dad031f3a9ff5bbc311d0ec8768b348b996bcf.1577271823.git.agx@sigxcpu.org> (raw)
In-Reply-To: <cover.1577271823.git.agx@sigxcpu.org>
The current is given by the formular from page 12 of
https://www.ti.com/lit/ds/symlink/lm36922.pdf. We use this to limit the
led's max_brightness using the led-max-microamp DT property.
The formular for the lm36923 is identical according to the data sheet.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
drivers/leds/leds-lm3692x.c | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
index ff20560a8263..d7e5de8fe8db 100644
--- a/drivers/leds/leds-lm3692x.c
+++ b/drivers/leds/leds-lm3692x.c
@@ -6,6 +6,7 @@
#include <linux/i2c.h>
#include <linux/init.h>
#include <linux/leds.h>
+#include <linux/log2.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/of.h>
@@ -320,11 +321,29 @@ static int lm3692x_init(struct lm3692x_led *led)
return ret;
}
+static enum led_brightness lm3692x_max_brightness(struct lm3692x_led *led,
+ u32 max_cur)
+{
+ u32 max_code;
+
+ /* see p.12 of LM36922 data sheet for brightness formula */
+ if (led->brightness_ctrl & LM3692X_MAP_MODE_EXP) {
+ /* 228 =~ 1.0 / log2(1.003040572) */
+ max_code = ilog2(max_cur/50) * 228;
+ } else {
+ max_code = ((max_cur * 1000) - 37806) / 12195;
+ }
+ if (max_code > 0x7FF)
+ max_code = 0x7FF;
+
+ return max_code >> 3;
+}
+
static int lm3692x_probe_dt(struct lm3692x_led *led)
{
struct fwnode_handle *child = NULL;
struct led_init_data init_data = {};
- u32 ovp;
+ u32 ovp, max_cur;
bool exp_mode;
int ret;
@@ -397,6 +416,10 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
return ret;
}
+ fwnode_property_read_u32(child, "led-max-microamp", &max_cur);
+ led->led_dev.max_brightness = ret ? LED_FULL :
+ lm3692x_max_brightness(led, max_cur);
+
init_data.fwnode = child;
init_data.devicename = led->client->name;
init_data.default_label = ":";
--
2.23.0
next prev parent reply other threads:[~2019-12-25 11:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 11:07 [PATCH v2 0/6] leds: lm3692x: Allow to set ovp and brigthness mode Guido Günther
2019-12-25 11:07 ` [PATCH v2 1/6] dt: bindings: lm3692x: Add ti,ovp-microvolt property Guido Günther
2019-12-26 10:06 ` Pavel Machek
2019-12-27 12:17 ` Guido Günther
2019-12-25 11:07 ` [PATCH v2 2/6] leds: lm3692x: Allow to configure over voltage protection Guido Günther
2019-12-26 10:07 ` Pavel Machek
2019-12-25 11:07 ` [PATCH v2 3/6] dt: bindings: lm3692x: Add ti,brightness-mapping-exponential property Guido Günther
2019-12-25 11:07 ` [PATCH v2 4/6] leds: lm3692x: Allow to configure brigthness mode Guido Günther
2019-12-25 11:07 ` [PATCH v2 5/6] dt: bindings: lm3692x: Add led-max-microamp property Guido Günther
2019-12-26 10:08 ` Pavel Machek
2019-12-25 11:07 ` Guido Günther [this message]
2019-12-26 10:13 ` [PATCH v2 6/6] leds: lm3692x: Make sure we don't exceed the maximum led current Pavel Machek
2019-12-27 12:59 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96dad031f3a9ff5bbc311d0ec8768b348b996bcf.1577271823.git.agx@sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).