From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Marco Felsch <m.felsch@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Support Opensource <Support.Opensource@diasemi.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [RESEND PATCH v3 3/3] pinctrl: da9062: add driver support
Date: Tue, 17 Dec 2019 09:55:38 +0000 [thread overview]
Message-ID: <AM5PR1001MB09945AA014D512511E4DF4A880500@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20191217064009.GB31182@pengutronix.de>
On 17 December 2019 06:40, Marco Felsch wrote:
> On 19-12-16 11:33, Linus Walleij wrote:
> > On Mon, Dec 16, 2019 at 8:47 AM Marco Felsch <m.felsch@pengutronix.de>
> wrote:
> >
> > > Nice catch, Linus is it okay to add this as follow up patch? The current
> > > patch isn't wrong without the 'PIN_CONFIG_BIAS_DISABLE' case.
> >
> > No strong opinion on that as long as the result is running code.
>
> Of course the code is running and was tested. Just didn't covered this
> use case.
>
> Adam is this okay with you?
If you want to send a follow up straight after then that's ok although to me
that seems like more effort. :)
Anyway:
Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
>
> Regards,
> Marco
>
> > Yours,
> > Linus Walleij
> >
prev parent reply other threads:[~2019-12-17 9:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 16:04 [RESEND PATCH v3 0/3] Add DA9062 GPIO support Marco Felsch
2019-12-12 16:04 ` [RESEND PATCH v3 1/3] dt-bindings: mfd: da9062: add gpio bindings Marco Felsch
2019-12-12 16:45 ` Adam Thomson
2019-12-13 10:38 ` Lee Jones
2019-12-18 21:54 ` Rob Herring
2019-12-12 16:04 ` [RESEND PATCH v3 2/3] mfd: da9062: add support for the DA9062 GPIOs in the core Marco Felsch
2019-12-12 16:45 ` Adam Thomson
2019-12-13 10:37 ` Lee Jones
2019-12-12 16:04 ` [RESEND PATCH v3 3/3] pinctrl: da9062: add driver support Marco Felsch
2019-12-12 16:48 ` Adam Thomson
2019-12-16 7:47 ` Marco Felsch
2019-12-16 10:33 ` Linus Walleij
2019-12-17 6:40 ` Marco Felsch
2019-12-17 9:55 ` Adam Thomson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR1001MB09945AA014D512511E4DF4A880500@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).