From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Malaterre Subject: Re: [PATCH v4 2/8] dt-bindings: ingenic: Add DT bindings for TCU clocks Date: Wed, 28 Mar 2018 20:35:50 +0200 Message-ID: References: <20180110224838.16711-2-paul@crapouillou.net> <20180317232901.14129-1-paul@crapouillou.net> <20180317232901.14129-3-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Paul Cercueil Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Lee Jones , Daniel Lezcano , Ralf Baechle , Rob Herring , Jonathan Corbet , Mark Rutland , James Hogan , Maarten ter Huurne , linux-clk@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Linux-MIPS , linux-doc@vger.kernel.org List-Id: devicetree@vger.kernel.org On Wed, Mar 28, 2018 at 5:04 PM, Paul Cercueil wrote= : > Le 2018-03-20 08:15, Mathieu Malaterre a =C3=A9crit : >> >> Hi Paul, >> >> Two things: >> >> On Sun, Mar 18, 2018 at 12:28 AM, Paul Cercueil >> wrote: >>> >>> This header provides clock numbers for the ingenic,tcu >>> DT binding. >> >> >> I have tested the whole series on my Creator CI20 with success, using: >> >> + tcu@10002000 { >> + compatible =3D "ingenic,jz4780-tcu"; >> + reg =3D <0x10002000 0x140>; >> + >> + interrupt-parent =3D <&intc>; >> + interrupts =3D <27 26 25>; >> + }; >> >> >> So: >> >> Tested-by: Mathieu Malaterre > > > Great! Is that for the whole patchset or just this one patch? The sentence just above was "whole series" :) so yes that was for the whole series. Technically I only tested it on JZ4780, I hope this is acceptable for the tag. > >>> Signed-off-by: Paul Cercueil >>> Reviewed-by: Rob Herring >>> --- >>> include/dt-bindings/clock/ingenic,tcu.h | 23 +++++++++++++++++++++++ >>> 1 file changed, 23 insertions(+) >>> create mode 100644 include/dt-bindings/clock/ingenic,tcu.h >>> >>> v2: Use SPDX identifier for the license >>> v3: No change >>> v4: No change >>> >>> diff --git a/include/dt-bindings/clock/ingenic,tcu.h >>> b/include/dt-bindings/clock/ingenic,tcu.h >>> new file mode 100644 >>> index 000000000000..179815d7b3bb >>> --- /dev/null >>> +++ b/include/dt-bindings/clock/ingenic,tcu.h >>> @@ -0,0 +1,23 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * This header provides clock numbers for the ingenic,tcu DT binding. >>> + */ >>> + >>> +#ifndef __DT_BINDINGS_CLOCK_INGENIC_TCU_H__ >>> +#define __DT_BINDINGS_CLOCK_INGENIC_TCU_H__ >>> + >>> +#define JZ4740_CLK_TIMER0 0 >>> +#define JZ4740_CLK_TIMER1 1 >>> +#define JZ4740_CLK_TIMER2 2 >>> +#define JZ4740_CLK_TIMER3 3 >>> +#define JZ4740_CLK_TIMER4 4 >>> +#define JZ4740_CLK_TIMER5 5 >>> +#define JZ4740_CLK_TIMER6 6 >>> +#define JZ4740_CLK_TIMER7 7 >>> +#define JZ4740_CLK_WDT 8 >>> +#define JZ4740_CLK_LAST JZ4740_CLK_WDT >>> + >>> +#define JZ4770_CLK_OST 9 >>> +#define JZ4770_CLK_LAST JZ4770_CLK_OST >>> + >> >> >> When working on JZ4780 support, I always struggle to read those kind >> of #define. Since this is a new patch would you mind changing >> s/JZ4740/JZ47XX/ in your header ? > > > Well the idea was that these defines are for JZ4740 and newer. > But that means all Ingenic SoCs, so I guess I can change it. > >> Thanks for your work on JZ ! > > > Sure, thank you for testing! > > >>> +#endif /* __DT_BINDINGS_CLOCK_INGENIC_TCU_H__ */ >>> -- >>> 2.11.0 >>> >>> >