From: Ikjoon Jang <ikjn@chromium.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org,
GregKroah-Hartman <gregkh@linuxfoundation.org>,
RobHerring <robh+dt@kernel.org>,
MarkRutland <mark.rutland@arm.com>,
AlanStern <stern@rowland.harvard.edu>,
SuwanKim <suwan.kim027@gmail.com>,
"GustavoA . R . Silva" <gustavo@embeddedor.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicolas Boichat <drinkcat@chromium.org>
Subject: Re: [PATCH v4 2/2] usb: overridable hub bInterval by device node
Date: Thu, 5 Dec 2019 15:32:38 +0800 [thread overview]
Message-ID: <CAATdQgBcuJenS2VSm+y4Yhn5mWE1P0CGJQ3NRdoe68dd2SRPGg@mail.gmail.com> (raw)
In-Reply-To: <20191204075533.GI10631@localhost>
On Wed, Dec 4, 2019 at 3:55 PM Johan Hovold <johan@kernel.org> wrote:
> > > > @@ -257,6 +258,14 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno, int inum,
> > > > memcpy(&endpoint->desc, d, n);
> > > > INIT_LIST_HEAD(&endpoint->urb_list);
> > > >
> > > > + /* device node property overrides bInterval */
> > > > + if (usb_of_has_combined_node(to_usb_device(ddev))) {
> > >
> > > Not only hubs have combined nodes so you probably need to check
> > > bDeviceClass here instead.
> >
> > yes, you're right, I didn't think of that case:
> > if (to_usb_device(ddev)->descriptor.bDeviceClass == USB_CLASS_HUB &&
> > ddev->of_node && !of_property_read_u32(...))
> >
> > Or is it better to check bInterfaceClass, for composite devices with a
> > hub interface inside?
> > if (ifp->desc.bInterfaceClass == USB_CLASS_HUB && ddev->of_node &&
> > !of_property_read_u32(...))
> >
> > I think checking bInterfaceClass is better.
>
> Yep, that seems better (but please use two conditionals for
> readability).
>
> But related to my question above, why do you need to do this during
> enumeration? Why not just set the lower interval value in the hub
> driver?
>
Because I want device tree's bInterval to be checked against the same rules
defined in usb_parse_endpoint(). e.g. although hardware says its maximum
is 255, but the practical limit is still 0 to 16, so the code can
print warnings when
bInterval from device node is too weird.
> > > > + u32 interval = 0;
> > > > + if (!of_property_read_u32(ddev->of_node, "hub,interval",
> > > > + &interval))
> > > > + d->bInterval = min_t(u8, interval, 255);
> > >
> > > You want min_t(u32, ...) here to avoid surprises when someone specifies
> > > a value > 255.
> >
> > yes, thanks.
>
> And I guess you should really be honouring bInterval as a maximum value,
> right?
Yes, right, not masking.
>
> > > > + }
> > > > +
> > > > /*
> > > > * Fix up bInterval values outside the legal range.
> > > > * Use 10 or 8 ms if no proper value can be guessed.
>
> Johan
next prev parent reply other threads:[~2019-12-05 7:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 10:15 [PATCH v4 2/2] usb: overridable hub bInterval by device node Ikjoon Jang
2019-12-03 15:23 ` Alan Stern
2019-12-04 7:07 ` Ikjoon Jang
2019-12-03 16:53 ` Johan Hovold
2019-12-04 7:04 ` Ikjoon Jang
2019-12-04 7:55 ` Johan Hovold
2019-12-05 7:32 ` Ikjoon Jang [this message]
2019-12-05 14:26 ` Johan Hovold
2019-12-06 3:57 ` Ikjoon Jang
2019-12-06 15:00 ` Alan Stern
2019-12-09 3:47 ` Ikjoon Jang
2019-12-06 15:26 ` Johan Hovold
2019-12-09 4:05 ` Ikjoon Jang
2019-12-10 15:02 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATdQgBcuJenS2VSm+y4Yhn5mWE1P0CGJQ3NRdoe68dd2SRPGg@mail.gmail.com \
--to=ikjn@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=suwan.kim027@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).