From: Linus Walleij <linus.walleij@linaro.org>
To: Danilo Krummrich <danilokrummrich@dk-develop.de>
Cc: krzysztof.kozlowski@canonical.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v3 2/2] dt-bindings: ps2-gpio: document bus signals open drain
Date: Mon, 30 May 2022 11:50:53 +0200 [thread overview]
Message-ID: <CACRpkdZ6ZaRRVzctb72oSbBL_Mwug5cZEKR7y_jbJ5N47psyFw@mail.gmail.com> (raw)
In-Reply-To: <20220529132638.13420-2-danilokrummrich@dk-develop.de>
On Sun, May 29, 2022 at 3:26 PM Danilo Krummrich
<danilokrummrich@dk-develop.de> wrote:
> The PS/2 bus defines data and clock line to be open drain, this should
> be reflected in the gpio flags set in the binding.
>
> Especially, this is important since the clock line sometimes is driven
> by the host while being used as interrupt source.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-05-30 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 13:26 [RESEND PATCH v3 1/2] dt-bindings: ps2-gpio: convert binding to json-schema Danilo Krummrich
2022-05-29 13:26 ` [RESEND PATCH v3 2/2] dt-bindings: ps2-gpio: document bus signals open drain Danilo Krummrich
2022-05-30 9:50 ` Linus Walleij [this message]
2022-06-05 14:09 ` Rob Herring
2022-05-30 9:51 ` [RESEND PATCH v3 1/2] dt-bindings: ps2-gpio: convert binding to json-schema Linus Walleij
2022-06-05 14:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ6ZaRRVzctb72oSbBL_Mwug5cZEKR7y_jbJ5N47psyFw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=danilokrummrich@dk-develop.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).