From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D421C07E9C for ; Wed, 14 Jul 2021 08:26:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04497613AB for ; Wed, 14 Jul 2021 08:26:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238509AbhGNI3q (ORCPT ); Wed, 14 Jul 2021 04:29:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238511AbhGNI3n (ORCPT ); Wed, 14 Jul 2021 04:29:43 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92539C061760 for ; Wed, 14 Jul 2021 01:26:52 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id u14so2261235ljh.0 for ; Wed, 14 Jul 2021 01:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8zfNM5YqJ9ia0d7b1JxsHsYsljSn9Qi6joq52XtjhSc=; b=EeRP5cYeC6+cRM+wF/8DpZgWNdBfy9oJSwyZ8rIhnn03+sBLW1qWs1zHamDZ3mTDuo +xyI+1NpIYnI3pRulS51eok/Tk2aSBs7dcYsRKJx5CTTcxhE+SCPiNpVl7iixUa2L42A dfqcujcDs8Ofst4Trj0vMw6uiRs5HVtarpJcK+8QZdZ5sUpWbJ81V8XlMrYBKg1G3zyi wCyAaQL2mTn1hnBMsXocBb+ofVC24EKbM0iL0YsW3ZBCytYA9oGhv5aaYH+o6j2HDbwT t2fG1VtW1X4DrG9BJhUHOh7ENRxGqMrhZw8lrGFv8AO5hnPDGzF6/5mKeAAao8TleGjl UBcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8zfNM5YqJ9ia0d7b1JxsHsYsljSn9Qi6joq52XtjhSc=; b=i0CwwR+xWra20bUb0kpJ4tZnkMpDskg3blznB8DPRz143mWap39xGBHchsjQ2O6idj CIFc8EFCHda00L23fORyc/uU+lq2mEnwNVSXsHMy00d/OOnSgaJL5gcNfyxFNl5YcWCY VR5H7KyPbtW6OIKZpYfPT1T1ADdJas+1EghxWY+I4p91XDyDoYucWhXmVSj07f1E1Sjq qZL2nihXgGLnkp0WJTbGcV56fzBYHezDgCTIoVxx8IkShPaqFXhNJRl+hseI9ActGq0N Nr/PA+Hl8RPqzTnXp7pCu9jq/s1+UH9h4iCU9OkCXnwq0L0ahw6rBh2vn1xVmSygTpDl AyPQ== X-Gm-Message-State: AOAM53158xwESQLgJ822IE5jJDuZbwKcqHr7hZ1Qxddt/6uVd0WLKsRK wYTE0C9+1iTVMCmYC+/+kl6PbfD4yBKVRR/Wyzw6Zw== X-Google-Smtp-Source: ABdhPJyrH3MVRoc/cKZlUL7NFDICRxRUvv+gmLgI6eAsl9jEWbS+zVKI/MD0QtSkYNVI9ntVf9RL77birvDsRMfycVQ= X-Received: by 2002:a2e:9b45:: with SMTP id o5mr8171451ljj.273.1626251210869; Wed, 14 Jul 2021 01:26:50 -0700 (PDT) MIME-Version: 1.0 References: <20210412122331.1631643-1-linus.walleij@linaro.org> <20210712130444.bois24oukqmxpg27@gilmour> <20210712145639.00004604@Huawei.com> <20210712141613.66hw4glnkqlw3n4d@gilmour> In-Reply-To: <20210712141613.66hw4glnkqlw3n4d@gilmour> From: Linus Walleij Date: Wed, 14 Jul 2021 10:26:39 +0200 Message-ID: Subject: Re: [PATCH] iio: st-sensors: Update ST Sensor bindings To: Maxime Ripard Cc: Jonathan Cameron , Jonathan Cameron , linux-iio , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 12, 2021 at 4:16 PM Maxime Ripard wrote: > > maxItems is set, but not minItems. > > Yeah, and if one is missing the other is added with the value of the > other. > > What the schema enforces currently is that (for the common part) the > interrupt list can be between 1 and 2 and then for a specific set of > compatibles (including the LIS3MDL) it has to be exactly 2. maxItems is not an intuitive naming to what it does so it creates bugs like this :/ Can you fix so it works with your PinePhone DTS and send a patch? Perhaps also add as an example so it doesn't happen again? > Even the common part looks weird though, it says that it can handle up > to three interrupts but has maxItems: 2? Maybe just drop maxItems for now? Yours, Linus Walleij