From: Rob Clark <robdclark@gmail.com>
To: David Heidelberg <david@ixit.cz>
Cc: Sharat Masetty <smasetty@codeaurora.org>,
Brian Masney <masneyb@onstation.org>,
Rob Clark <robdclark@chromium.org>,
Jordan Crouse <jordan@cosmicpenguin.net>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] RFC: dt-bindings: drm/msm/gpu: convert to YAML
Date: Mon, 12 Jul 2021 08:18:46 -0700 [thread overview]
Message-ID: <CAF6AEGsAjjUtj=kE2Q5WFmfXsWcEG2K2=tfopuUK1ud4Z-6fMA@mail.gmail.com> (raw)
In-Reply-To: <20210703151835.171313-1-david@ixit.cz>
On Sat, Jul 3, 2021 at 8:20 AM David Heidelberg <david@ixit.cz> wrote:
>
> This warning cannot be fixed by conversion, since this naming is already used.
> Documentation/devicetree/bindings/display/msm/gpu.example.dt.yaml: gpu@5000000: interconnect-names: ['gfx-mem'] is too short
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> .../devicetree/bindings/display/msm/gpu.txt | 157 -----------
> .../devicetree/bindings/display/msm/gpu.yaml | 256 ++++++++++++++++++
> 2 files changed, 256 insertions(+), 157 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/msm/gpu.txt
> create mode 100644 Documentation/devicetree/bindings/display/msm/gpu.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt
> deleted file mode 100644
[snip]
> diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml
> new file mode 100644
> index 000000000000..4315482e0b12
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml
[snip]
> + zap-shader:
> + description: |
> + For a5xx and a6xx devices this node contains a memory-region that
> + points to reserved memory to store the zap shader that can be used to
> + help bring the GPU out of secure mode.
> +
Side note, this node is optional now, we do have some a6xx devices out
there which do not use/require a zap shader (in particular, the
chromebooks). Not sure if that effects how you want to document it in
the yaml.
Also, new dts for devices that use zap, they should specify a
"firmware-name", since the zap shader is usually signed with a board
specific signing key.
BR,
-R
prev parent reply other threads:[~2021-07-12 15:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 15:18 [PATCH] RFC: dt-bindings: drm/msm/gpu: convert to YAML David Heidelberg
2021-07-04 8:18 ` Dmitry Baryshkov
2021-07-04 9:31 ` David Heidelberg
2021-07-12 14:51 ` Rob Herring
2021-07-12 15:08 ` Rob Clark
2021-07-12 15:18 ` Rob Clark [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF6AEGsAjjUtj=kE2Q5WFmfXsWcEG2K2=tfopuUK1ud4Z-6fMA@mail.gmail.com' \
--to=robdclark@gmail.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=jordan@cosmicpenguin.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=robdclark@chromium.org \
--cc=smasetty@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).