From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lukasz Stelmach <l.stelmach@samsung.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Andrew Lunn" <andrew@lunn.ch>,
jim.cromie@gmail.com, linux-arm-kernel@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board
Date: Tue, 6 Oct 2020 12:17:02 +0200 [thread overview]
Message-ID: <CAJKOXPePumx3-v7Odp8Fv65gzXFZw+EkZCaX-YE-CYrrmyr-8g@mail.gmail.com> (raw)
In-Reply-To: <dleftj362rekjw.fsf%l.stelmach@samsung.com>
On Tue, 6 Oct 2020 at 12:06, Lukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote:
> > On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
> >>
> >> Add node for ax88796c ethernet chip.
> >>
> >> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> >> ---
> >> arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 ++++++++++++++++++++
> >> 1 file changed, 21 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> >> index 20446a846a98..7f115c348a2a 100644
> >> --- a/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> >> +++ b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> >> @@ -37,3 +37,24 @@ &mshc_2 {
> >> &serial_2 {
> >> status = "okay";
> >> };
> >> +
> >> +&spi_0 {
> >> + status = "okay";
> >> + cs-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>, <0>;
> >> +
> >> + assigned-clocks = <&cmu CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>, <&cmu CLK_DIV_SPI0>, <&cmu CLK_DIV_SPI0_PRE>, <&cmu CLK_SCLK_SPI0>;
> >
> > No spaces before or after '='.
> >
>
> You mean " = ", don't you?
Ah, of course.
>
> >> + assigned-clock-parents = <&cmu CLK_FOUT_MPLL>, <&cmu
> >> CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>, <&cmu
> >> CLK_DIV_SPI0>, <&cmu CLK_DIV_SPI0_PRE>;
> >
> > This line is still too long. Please wrap it at 80. Checkpatch should
> > complain about it... so it seems you did not run it. Please fix all
> > checkpatch issues.
>
> My idea was too keep assigned-clocks and assigned-clock-parrent lines
> aligned, so it is clearly visible which parrent applies to which
> clock. Is it inappropriate?
The line gets too long and in the existing DTSes we wrapped item by
item. Solution could be to add comments, e.g.:
assigned-clock-parents = <&cmu CLK_FOUT_MPLL>,
<&cmu CLK_DIV_MPLL_PRE>, /* for: CLK_DIV_MPLL_PRE */
<&cmu CLK_MOUT_SPI0>, /* for: CLK_MOUT_SPI0 */
but I am not sure if dtc allows such comments.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-10-06 10:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201002192215eucas1p2c8f4a4bf8e411ed8ba75383fd58e85ac@eucas1p2.samsung.com>
2020-10-02 19:22 ` [PATCH v2 0/4] AX88796C SPI Ethernet Adapter Łukasz Stelmach
[not found] ` <CGME20201002192215eucas1p2c1d2baebfe2a9caa11d88175a2899fea@eucas1p2.samsung.com>
2020-10-02 19:22 ` [PATCH v2 1/4] dt-bindings: net: Add bindings for " Łukasz Stelmach
2020-10-03 10:09 ` Krzysztof Kozlowski
2020-10-05 14:03 ` Rob Herring
2020-10-05 13:59 ` Rob Herring
2020-10-05 14:01 ` Krzysztof Kozlowski
[not found] ` <CGME20201002192216eucas1p16f54584cf50fff56edc278102a66509e@eucas1p1.samsung.com>
2020-10-02 19:22 ` [PATCH v2 2/4] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Łukasz Stelmach
2020-10-02 20:36 ` Andrew Lunn
[not found] ` <CGME20201013200453eucas1p1b77c93275b518422429ff1481f88a4be@eucas1p1.samsung.com>
2020-10-13 20:04 ` Lukasz Stelmach
2020-10-16 18:01 ` Andrew Lunn
[not found] ` <CGME20201016191905eucas1p235fb430a8f330a39e64f4fd6b81decb2@eucas1p2.samsung.com>
2020-10-16 19:18 ` Lukasz Stelmach
[not found] ` <CGME20201019125624eucas1p257a76c307adfb27202332658f93c9aba@eucas1p2.samsung.com>
2020-10-19 12:56 ` Lukasz Stelmach
2020-10-19 13:02 ` Andrew Lunn
2020-10-03 12:59 ` Heiner Kallweit
[not found] ` <CGME20201013200250eucas1p2445005531b86f246d7a14b7fc8016e80@eucas1p2.samsung.com>
2020-10-13 20:02 ` Lukasz Stelmach
[not found] ` <CGME20201002192216eucas1p16933608dcb0fb8ceee21caa3455cbaf1@eucas1p1.samsung.com>
2020-10-02 19:22 ` [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board Łukasz Stelmach
2020-10-03 10:13 ` Krzysztof Kozlowski
[not found] ` <CGME20201006100556eucas1p2b69f76968a7a5901b5e9c66338c388d4@eucas1p2.samsung.com>
2020-10-06 10:05 ` Lukasz Stelmach
2020-10-06 10:17 ` Krzysztof Kozlowski [this message]
[not found] ` <CGME20201006140300eucas1p2006a96630d4a825500e5fc72016cf9d7@eucas1p2.samsung.com>
2020-10-06 14:02 ` Lukasz Stelmach
[not found] ` <CGME20201002192217eucas1p2357f80b100fb130d1ef1ac281042ff7c@eucas1p2.samsung.com>
2020-10-02 19:22 ` [PATCH v2 4/4] ARM: defconfig: Enable ax88796c driver Łukasz Stelmach
2020-10-02 19:45 ` [PATCH v2 0/4] AX88796C SPI Ethernet Adapter Andrew Lunn
[not found] ` <CGME20201006083749eucas1p160a3bed4cdb67cc8e05ca4a57d8907ca@eucas1p1.samsung.com>
2020-10-06 8:37 ` Lukasz Stelmach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPePumx3-v7Odp8Fv65gzXFZw+EkZCaX-YE-CYrrmyr-8g@mail.gmail.com \
--to=krzk@kernel.org \
--cc=andrew@lunn.ch \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jim.cromie@gmail.com \
--cc=kgene@kernel.org \
--cc=kuba@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).