From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine <dmaengine@vger.kernel.org>,
Timur Tabi <timur@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V7 2/7] ACPI / bus: Introduce acpi_get_match_data() function
Date: Fri, 8 Dec 2017 15:51:16 +0100 [thread overview]
Message-ID: <CAJZ5v0iw1u4o0SbCN12ctG+Kpg0EP+JBGvToLyiEcQopY=KPzw@mail.gmail.com> (raw)
In-Reply-To: <1512681031-11343-3-git-send-email-okaya@codeaurora.org>
On Thu, Dec 7, 2017 at 10:10 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
> OF has of_device_get_match_data() function to extract driver specific data
> structure. Add a similar function for ACPI.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> ---
> drivers/acpi/bus.c | 18 ++++++++++++++++++
> include/linux/acpi.h | 6 ++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 4d0979e..f87ed3b 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -785,6 +785,24 @@ const struct acpi_device_id *acpi_match_device(const struct acpi_device_id *ids,
> }
> EXPORT_SYMBOL_GPL(acpi_match_device);
>
> +void *acpi_get_match_data(const struct device *dev)
> +{
> + const struct acpi_device_id *match;
> +
> + if (!dev->driver)
> + return NULL;
> +
> + if (!dev->driver->acpi_match_table)
> + return NULL;
You can safely check dev->driver and this in the same statement (as
long as the first check to be made is on the left).
> +
> + match = acpi_match_device(dev->driver->acpi_match_table, dev);
> + if (!match)
> + return NULL;
> +
> + return (void *)match->driver_data;
> +}
> +EXPORT_SYMBOL_GPL(acpi_get_match_data);
> +
> int acpi_match_device_ids(struct acpi_device *device,
> const struct acpi_device_id *ids)
> {
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 502af53..a927260 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -584,6 +584,7 @@ extern int acpi_nvs_for_each_region(int (*func)(__u64, __u64, void *),
> const struct acpi_device_id *acpi_match_device(const struct acpi_device_id *ids,
> const struct device *dev);
>
> +void *acpi_get_match_data(const struct device *dev);
> extern bool acpi_driver_match_device(struct device *dev,
> const struct device_driver *drv);
> int acpi_device_uevent_modalias(struct device *, struct kobj_uevent_env *);
> @@ -755,6 +756,11 @@ static inline const struct acpi_device_id *acpi_match_device(
> return NULL;
> }
>
> +static inline void *acpi_get_match_data(const struct device *dev)
> +{
> + return NULL;
> +}
> +
> static inline bool acpi_driver_match_device(struct device *dev,
> const struct device_driver *drv)
> {
> --
But anyway
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
next prev parent reply other threads:[~2017-12-08 14:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 21:10 [PATCH V7 0/7] dmaengine: qcom_hidma: add support for bugfixed HW Sinan Kaya
2017-12-07 21:10 ` [PATCH V7 1/7] Documentation: DT: qcom_hidma: Bump HW revision for the " Sinan Kaya
2017-12-07 21:10 ` [PATCH V7 2/7] ACPI / bus: Introduce acpi_get_match_data() function Sinan Kaya
2017-12-08 14:51 ` Rafael J. Wysocki [this message]
2017-12-07 21:10 ` [PATCH V7 3/7] device property: Introduce a common API to fetch device match data Sinan Kaya
2017-12-07 21:10 ` [PATCH V7 4/7] OF: properties: Implement get_match_data() callback Sinan Kaya
2017-12-07 21:10 ` [PATCH V7 5/7] ACPI: " Sinan Kaya
2017-12-08 14:51 ` Rafael J. Wysocki
2017-12-07 21:10 ` [PATCH V7 6/7] dmaengine: qcom_hidma: Add support for the new revision Sinan Kaya
2017-12-07 21:10 ` [PATCH V7 7/7] dmaengine: qcom_hidma: Add identity register support Sinan Kaya
2017-12-08 13:48 ` [PATCH V7 0/7] dmaengine: qcom_hidma: add support for bugfixed HW Rafael J. Wysocki
2017-12-08 14:44 ` Sinan Kaya
2017-12-10 16:39 ` Vinod Koul
2017-12-12 5:38 ` Vinod Koul
2017-12-12 12:36 ` Rafael J. Wysocki
2017-12-13 0:09 ` Sinan Kaya
2017-12-13 0:44 ` Sinan Kaya
2017-12-13 3:19 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0iw1u4o0SbCN12ctG+Kpg0EP+JBGvToLyiEcQopY=KPzw@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).