From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B7AC433F5 for ; Thu, 9 Dec 2021 08:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232739AbhLIIjs (ORCPT ); Thu, 9 Dec 2021 03:39:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbhLIIjr (ORCPT ); Thu, 9 Dec 2021 03:39:47 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF285C061746 for ; Thu, 9 Dec 2021 00:36:14 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id v23so3880614pjr.5 for ; Thu, 09 Dec 2021 00:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gPSjlKUX+9Y5n3Sl0KL4uogsgbWr6pQzNUKzPDrEag4=; b=G7/Osq/HdjMvsJZjUwRfMyRbmVjGGXZpTKgarrqHDrUumHPJ1ehTj8it04M095FdrM Fn6RLK+ICZBDRLHJ9Ji9y66nI9SAl83MQ9Dox3m2la7OAUAvGLYn7k/yCrBudjYAmwxn t+i2KZMc2qzpZUyptdwwVfJR7sHpJw02H3F2M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gPSjlKUX+9Y5n3Sl0KL4uogsgbWr6pQzNUKzPDrEag4=; b=d0UChvlFn2x5tRhsd/7ReTxcBaMakfYDrn9mYfWQ64Rj96RIzOat6csdnU7HYU7+nE ABOmr/h2Mit5tCk/N/t5WpP32SBhY/EousNudL3ihXhEKsWaB9AfQFMT1Ox+SShifvSi Rcw6kIX/Bt6Z2znt6IbJN/DOBUEe4WEsd9NZ77rpvnOD3YBQqtz3hW+3VYg8pu+MFL7x sF3FdbfIgpSczfIzxlWD4Zr5X+TVdxan4OWfXASwW4GA82JlFpXXwykYoZKEPGz9kvow gY6lyGlT9n0EJrhoG8f9T/Zn+6nHrbCBQ5yrCknnIO1pheOR23r7Rmml0T4/cjjTuPUS 4WBA== X-Gm-Message-State: AOAM532g09vvN1dB8TX7iL66BYlSXKCSUYsZkWWoVLHBW0h9ZQxqXysY +yUuZ8pXzOoBNeclT4lU31o3fChxYzBlzfjuYpIktA== X-Google-Smtp-Source: ABdhPJw1c0KcLi7N1D0PrOBHMYuJDIXaLytxTcKjVE/FYrLOKMR01K4Ff3ReAIBG4TbdHAkUD9WaMzuK76CUVt18pSw= X-Received: by 2002:a17:902:8302:b0:143:6e5f:a4a0 with SMTP id bd2-20020a170902830200b001436e5fa4a0mr65790309plb.20.1639038974084; Thu, 09 Dec 2021 00:36:14 -0800 (PST) MIME-Version: 1.0 References: <20210704090230.26489-1-jagan@amarulasolutions.com> In-Reply-To: From: Michael Nazzareno Trimarchi Date: Thu, 9 Dec 2021 09:36:02 +0100 Message-ID: Subject: Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge To: Tim Harvey Cc: Jagan Teki , Sam Ravnborg , Marek Vasut , devicetree , linux-samsung-soc , Joonyoung Shim , Neil Armstrong , linux-amarula , dri-devel , Krzysztof Kozlowski , Seung-Woo Kim , Robert Foss , Frieder Schrempf , Andrzej Hajda , Kyungmin Park , Laurent Pinchart , Daniel Vetter , linux-arm-kernel , NXP Linux Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Tim On Tue, Oct 5, 2021 at 11:43 PM Tim Harvey wrote: > > On Sun, Jul 25, 2021 at 10:14 AM Jagan Teki wrote: > > > > Hi Sam, > > > > On Sun, Jul 25, 2021 at 10:35 PM Sam Ravnborg wrote: > > > > > > Hi Jagan, > > > > > > On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote: > > > > This series supports common bridge support for Samsung MIPI DSIM > > > > which is used in Exynos and i.MX8MM SoC's. > > > > > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > > > > > Right now bridge offers two sets of implementations. > > > > > > > > A. With component_ops and exynos specific code exclusively for > > > > exynos dsi drivers and it's legacy bindings. > > > > > > > > B. Without componenet_ops for newly implemented bridges and its > > > > users like i.MX8MM. > > > > > > > > The future plan is to fix the implementation A) by dropping > > > > component_ops and fixing exynos specific code in order to make > > > > the bridge more mature to use and the same is mentioned in > > > > drivers TODO. > > > > > > > > Patch 0001 - 0006: Bridge conversion > > > > Patch 0007 - 0017: Samsung MIPI DSIM bridge fixes, additions > > > > > > > > Tested in Engicam i.Core MX8M Mini SoM. > > > > > > > > Anyone interest, please have a look on this repo > > > > https://github.com/openedev/linux/tree/070421-imx8mm-dsim > > > > > > > > Would appreciate anyone from the exynos team to test it on > > > > the exynos platform? > > > > > > > > Any inputs? > > > > > > I really like where you are headign with this! > > > No testing - sorry. But I will try to provide a bit of feedback on the > > > individual patches. > > > > > > I hope you find a way to move forward with this. > > > > Thanks for the response. > > > > We have found some issues with Bridge conversion on existing exynos > > drivers. The component based DSI drivers(like exynos) are difficult to > > attach if it involves kms hotplug. kms hotplug would require drm > > pointer and that pointer would only available after the bind call > > finishes. But the bridge attach in bind call will defer till it find > > the attached bridge. > > > > Right now I'm trying to find the proper way to attach the bridges for > > component based DSI drivers which involves kms hot-plug. > > > > If you have any ideas on this, please let me know. > > > > Jagan, > > How is your progress on this series? Looking at your repo it looks > like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim > branch but you've got a lot of things there that are likely not > related to this series? I have a bit of work on those patches and tested on imx8mn. Basically: - add the dsi timing calculation - change few difference with samsung bridge - fix crashes of my dsi panels - compare with NXP driver the final results I found that I have one problem that gives me some instability. In the NXP original driver the panel needs to be enabled in bridge_enable before out the standby. If I understand correctly, our standby should be done after. I would like to have some feedback and help and testing on other boards/devices and some suggestions on how to handle some of the differences. Another big problem is etnavi that is not stable Michael > > Best regards, > > Tim > > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com