From: Shubhrajyoti Datta <shubhraj@xilinx.com>
To: Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Michal Simek <michals@xilinx.com>
Subject: RE: [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor
Date: Thu, 21 Nov 2019 09:04:38 +0000 [thread overview]
Message-ID: <MN2PR02MB60943664B80D3028F8422175AA4E0@MN2PR02MB6094.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20191010214835.GA4523@bogus>
Hi,
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, October 11, 2019 3:19 AM
> To: Shubhrajyoti Datta <shubhraj@xilinx.com>
> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
> arnd@arndb.de; gregkh@linuxfoundation.org; Michal Simek
> <michals@xilinx.com>
> Subject: Re: [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc
> Performance Monitor
>
> On Thu, Sep 26, 2019 at 10:46:24AM +0530, Shubhrajyoti Datta wrote:
> > Add dt bindings for flexnoc Performance Monitor.
> > The flexnoc counters for read and write response and requests are
> > supported.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> > ---
> > .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24
> ++++++++++++++++++++++
>
> bindings/perf/
>
> Please convert this to a schema. See
> Documentation/devicetree/writing-schema.rst.
Ok
>
> > 1 file changed, 24 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> >
> > diff --git a/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> > b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> > new file mode 100644
> > index 0000000..6b533bc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> > @@ -0,0 +1,24 @@
> > +* Xilinx Flexnoc Performance Monitor driver
>
> Bindings are for h/w blocks, not drivers.
Wil change
>
> > +
> > +The FlexNoc Performance Monitor has counters for monitoring the read
> > +and the write transaction counter.
> > +
> > +Required properties:
> > +- compatible: "xlnx,flexnoc-pm-2.7"
> > +- reg : Address and length of register sets for each device in
> > + "reg-names"
> > +- reg-names : The names of the register addresses corresponding to the
> > + registers filled in "reg"
> > + - funnel: base address of the funnel registers
> > + - baselpd: base address of the LPD PM registers
> > + - basefpd: base address FPD PM registers
>
> Is this really all one h/w block.
>
> FlexNoC is an interconnect, right? Is there more to it than just perfmon?
Yes , however the driver only uses the monitoring part.
>
> > +
prev parent reply other threads:[~2019-11-21 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 5:16 [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor Shubhrajyoti Datta
2019-09-26 5:16 ` [RFC PATCHv2 2/3] misc: xilinx_flex: Add support for the " Shubhrajyoti Datta
2019-09-26 5:16 ` [RFC PATCHv2 3/3] Documentation: short descriptions for Flexnoc Performance Monitor driver Shubhrajyoti Datta
2019-09-26 5:29 ` [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor Greg KH
2019-10-10 21:48 ` Rob Herring
2019-11-21 9:04 ` Shubhrajyoti Datta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR02MB60943664B80D3028F8422175AA4E0@MN2PR02MB6094.namprd02.prod.outlook.com \
--to=shubhraj@xilinx.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).