From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C3B5C433ED for ; Thu, 15 Apr 2021 19:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65344601FD for ; Thu, 15 Apr 2021 19:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234716AbhDOTJv (ORCPT ); Thu, 15 Apr 2021 15:09:51 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:50858 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234226AbhDOTJv (ORCPT ); Thu, 15 Apr 2021 15:09:51 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 452C189A; Thu, 15 Apr 2021 21:09:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618513766; bh=INJUqYChGzaADsZcMlE0KVTNy5xAuq64jBEaD2riYD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XFLQ5ymwmWOPUH4e++viERDpFMCmvRqLyVVjRCOoA3Wl3varwFEunZ2h3vKWoLEu0 uXCQOyr8xYR9Gq5KJU6sQLDqqhpPdQOkZomFu6LIdkl8fWHnawvao5Ha2hsdRBh1ox jAvi/naiFHcU0yvsX7jFdOU8u3Yt3qdLnSVKa3D8= Date: Thu, 15 Apr 2021 22:09:24 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Jacopo Mondi , Magnus Damm , Kieran Bingham , Rob Herring , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Niklas =?utf-8?Q?S=C3=B6derlund?= Subject: Re: [PATCH v4 4/7] arm64: dts: renesas: r8a77970: Add csi40 port@0 Message-ID: References: <20210415122602.87697-1-jacopo+renesas@jmondi.org> <20210415122602.87697-5-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Apr 15, 2021 at 06:47:48PM +0200, Geert Uytterhoeven wrote: > On Thu, Apr 15, 2021 at 4:47 PM Laurent Pinchart wrote: > > On Thu, Apr 15, 2021 at 02:25:59PM +0200, Jacopo Mondi wrote: > > > Declare port@0 in the csi40 device node and leave it un-connected. > > > Each board .dts file will connect the port as it requires. > > > > > > Signed-off-by: Jacopo Mondi > > > > The port exists at the hardware level, so including it here sounds good. > > The DT binding even makes the port mandatory :-) > > But the latter is subject to change? > > [PATCH] media: dt-bindings: media: renesas,csi2: Node port@0 is not mandatory > https://lore.kernel.org/linux-devicetree/20210413155346.2471776-1-niklas.soderlund+renesas@ragnatech.se/ I've replied to that patch, it's not a good idea. > > > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi > > > @@ -1106,6 +1106,10 @@ ports { > > > #address-cells = <1>; > > > #size-cells = <0>; > > > > > > + port@0 { > > > + reg = <0>; > > > + }; > > > + > > > port@1 { > > > #address-cells = <1>; > > > #size-cells = <0>; -- Regards, Laurent Pinchart