From: Krzysztof Adamski <krzysztof.adamski@nokia.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Przemyslaw Cencner <przemyslaw.cencner@nokia.com>
Subject: Re: [PATCH v2 04/10] hwmon: (tmp421) add support for defining labels from DT
Date: Fri, 24 Sep 2021 14:27:31 +0200 [thread overview]
Message-ID: <YU3EM8SJ9GA83PhP@localhost.localdomain> (raw)
In-Reply-To: <20210924121706.GA2696746@roeck-us.net>
Dnia Fri, Sep 24, 2021 at 05:17:06AM -0700, Guenter Roeck napisał(a):
>> +static int tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data)
>> +{
>> + struct device *dev = &client->dev;
>> + const struct device_node *np = dev->of_node;
>> + struct device_node *child;
>> + int err;
>> +
>> + for_each_child_of_node(np, child) {
>> + err = tmp421_probe_child_from_dt(client, child, data);
>> + if (err)
>> + return err;
>> + }
>
>That makes me wonder: Can there ever be other (not temperature channel
>related) child nodes ? Power, for example ?
For this device? Nothing that could think of that could make sense. But
we can be stricter here and skip/ignore all the nodes that are not named
input@X, if you think that is reasonable.
Krzysztof
next prev parent reply other threads:[~2021-09-24 12:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 9:36 [PATCH v2 00/10] Add per channel properies support in tmp421 Krzysztof Adamski
2021-09-24 9:38 ` [PATCH v2 01/10] dt-bindings: hwmon: add missing tmp421 binding Krzysztof Adamski
2021-09-24 12:45 ` Rob Herring
2021-09-24 12:54 ` Krzysztof Adamski
2021-09-24 9:39 ` [PATCH v2 02/10] hwmon: (tmp421) introduce MAX_CHANNELS define Krzysztof Adamski
2021-09-24 12:05 ` Guenter Roeck
2021-09-24 9:39 ` [PATCH v2 03/10] hwmon: (tmp421) introduce a channel struct Krzysztof Adamski
2021-09-24 9:39 ` [PATCH v2 04/10] hwmon: (tmp421) add support for defining labels from DT Krzysztof Adamski
2021-09-24 12:17 ` Guenter Roeck
2021-09-24 12:27 ` Krzysztof Adamski [this message]
2021-09-24 9:40 ` [PATCH v2 05/10] hwmon: (tmp421) support disabling channels " Krzysztof Adamski
2021-09-24 9:40 ` [PATCH v2 06/10] hwmon: (tmp421) support specifying n-factor via DT Krzysztof Adamski
2021-09-24 9:42 ` [PATCH v2 07/10] hwmon: (tmp421) really disable channels Krzysztof Adamski
2021-09-24 12:12 ` Guenter Roeck
2021-09-24 9:43 ` [PATCH v2 08/10] hwmon: (tmp421) support HWMON_T_ENABLE Krzysztof Adamski
2021-09-24 9:44 ` [PATCH v2 09/10] hwmon: (tmp421) update documentation Krzysztof Adamski
2021-09-24 9:44 ` [PATCH v2 10/10] dt-bindings: hwmon: allow specifying channels for tmp421 Krzysztof Adamski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU3EM8SJ9GA83PhP@localhost.localdomain \
--to=krzysztof.adamski@nokia.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=przemyslaw.cencner@nokia.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).