From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rudraksha Gupta <guptarud@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: david@ixit.cz, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/5] ARM: Add Samsung Galaxy Express support
Date: Tue, 30 May 2023 15:20:47 +0200 [thread overview]
Message-ID: <d2a69542-14e3-ea15-0c21-93d0df19fbf8@linaro.org> (raw)
In-Reply-To: <20230524230459.120681-5-guptarud@gmail.com>
On 25/05/2023 01:04, Rudraksha Gupta wrote:
> This adds a very basic device tree file for the Samsung Galaxy Express
> SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and
> USB.
>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
> +
> +&usb_hs1_phy {
> + v3p3-supply = <&pm8921_l3>;
> + v1p8-supply = <&pm8921_l4>;
> +};
> +
> +&usb1 {
> + status = "okay";
> + dr_mode = "otg";
> +};
> +
except what was said - drop stray blank line.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-30 13:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 23:04 [PATCH 1/5] ARM: Add label to sleep_clk in qcom-msm8960.dtsi Rudraksha Gupta
2023-05-24 23:04 ` [PATCH 2/5] ARM: Add samsung,expressatt to qcom.yaml Rudraksha Gupta
2023-05-30 13:19 ` Krzysztof Kozlowski
2023-05-24 23:04 ` [PATCH 3/5] ARM: Add qcom,usb-hs-phy-msm8960 to qcom,usb-hs-phy.yaml Rudraksha Gupta
2023-05-30 13:19 ` Krzysztof Kozlowski
2023-05-24 23:04 ` [PATCH 4/5] ARM: Blindly copy the usb node from apq8064.dtsi Rudraksha Gupta
2023-05-26 23:30 ` Konrad Dybcio
2023-05-24 23:04 ` [PATCH 5/5] ARM: Add Samsung Galaxy Express support Rudraksha Gupta
2023-05-26 23:36 ` Konrad Dybcio
2023-05-30 13:20 ` Krzysztof Kozlowski [this message]
2023-05-27 4:09 ` [PATCH 1/5] ARM: Add label to sleep_clk in qcom-msm8960.dtsi Bjorn Andersson
2023-05-28 0:10 ` [PATCH v2 0/4] Samsung Galaxy Express SGH-I437 Support Rudraksha Gupta
2023-05-30 13:21 ` Krzysztof Kozlowski
2023-05-28 0:10 ` [PATCH v2 1/4] dt-bindings: arm: qcom: Add Samsung Galaxy Express Rudraksha Gupta
[not found] ` <20230528-decode-creasing-f5b3996163e5@spud>
2023-05-28 13:36 ` Rudraksha Gupta
2023-05-29 7:41 ` Konrad Dybcio
2023-05-29 22:28 ` Rudraksha Gupta
[not found] ` <20230529-bonsai-during-37a47a528ff3@spud>
2023-05-29 22:50 ` Rudraksha Gupta
2023-05-30 12:57 ` Krzysztof Kozlowski
2023-05-28 0:10 ` [PATCH v2 2/4] dt-bindings: Add qcom,usb-hs-phy-msm8960 Rudraksha Gupta
2023-05-30 13:22 ` Krzysztof Kozlowski
2023-05-31 2:49 ` Rudraksha Gupta
2023-05-31 2:56 ` Dmitry Baryshkov
2023-05-28 0:10 ` [PATCH v2 3/4] ARM: dts: qcom: msm8960: Add USB node Rudraksha Gupta
2023-05-30 13:22 ` Krzysztof Kozlowski
2023-05-28 0:10 ` [PATCH v2 4/4] ARM: dts: qcom: Add Samsung Galaxy Express support Rudraksha Gupta
2023-05-30 13:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2a69542-14e3-ea15-0c21-93d0df19fbf8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=guptarud@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).