From: Oleksij Rempel <linux@rempel-privat.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Philippe Schenker <philippe.schenker@toradex.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH/RFC 1/5] dt-bindings: net: renesas,ravb: Document internal clock delay properties
Date: Sat, 20 Jun 2020 07:47:16 +0200 [thread overview]
Message-ID: <e6d0bfc5-9d75-2dc9-2bfa-671c32cb0b7c@rempel-privat.de> (raw)
In-Reply-To: <20200619191554.24942-2-geert+renesas@glider.be>
Hi Geert,
Am 19.06.20 um 21:15 schrieb Geert Uytterhoeven:
> Some EtherAVB variants support internal clock delay configuration, which
> can add larger delays than the delays that are typically supported by
> the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps"
> properties).
>
> Add properties for configuring the internal MAC delays.
> These properties are mandatory, even when specified as zero, to
> distinguish between old and new DTBs.
>
> Update the example accordingly.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../devicetree/bindings/net/renesas,ravb.txt | 29 ++++++++++---------
> 1 file changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> index 032b76f14f4fdb38..488ada78b6169b8e 100644
> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> @@ -64,6 +64,18 @@ Optional properties:
> AVB_LINK signal.
> - renesas,ether-link-active-low: boolean, specify when the AVB_LINK signal is
> active-low instead of normal active-high.
> +- renesas,rxc-delay-ps: Internal RX clock delay.
may be it make sense to add a generic delay property for MACs and PHYs?
> + This property is mandatory and valid only on R-Car Gen3
> + and RZ/G2 SoCs.
> + Valid values are 0 and 1800.
> + A non-zero value is allowed only if phy-mode = "rgmii".
> + Zero is not supported on R-Car D3.
> +- renesas,txc-delay-ps: Internal TX clock delay.
> + This property is mandatory and valid only on R-Car H3,
> + M3-W, M3-W+, M3-N, V3M, and V3H, and RZ/G2M and RZ/G2N.
> + Valid values are 0 and 2000.
In the driver i didn't found sanity check for valid values.
> + A non-zero value is allowed only if phy-mode = "rgmii".
> + Zero is not supported on R-Car V3H.> Example:
>
> @@ -105,8 +117,10 @@ Example:
> "ch24";
> clocks = <&cpg CPG_MOD 812>;
> power-domains = <&cpg>;
> - phy-mode = "rgmii-id";
> + phy-mode = "rgmii";
> phy-handle = <&phy0>;
> + renesas,rxc-delay-ps = <0>;
> + renesas,txc-delay-ps = <2000>;
>
> pinctrl-0 = <ðer_pins>;
> pinctrl-names = "default";
> @@ -115,18 +129,7 @@ Example:
> #size-cells = <0>;
>
> phy0: ethernet-phy@0 {
> - rxc-skew-ps = <900>;
> - rxdv-skew-ps = <0>;
> - rxd0-skew-ps = <0>;
> - rxd1-skew-ps = <0>;
> - rxd2-skew-ps = <0>;
> - rxd3-skew-ps = <0>;
> - txc-skew-ps = <900>;
> - txen-skew-ps = <0>;
> - txd0-skew-ps = <0>;
> - txd1-skew-ps = <0>;
> - txd2-skew-ps = <0>;
> - txd3-skew-ps = <0>;
> + rxc-skew-ps = <1500>;
I'm curios, how this numbers ware taken?
Old configurations was:
TX delay:
(txd*-skew-ps = 0) == -420ns
(txc-skew-ps = 900) == 0ns
resulting delays 0.420ns
RX delay:
(rxd*-skew-ps = 0) == -420ns
(rxc-skew-ps = 900) == 0ns
internal delay 1.2 + 420ns will be 1.62ns
I was not able to find actual delay values provided by the MAC. But from your patches it looks like 2ns.
So, end result will be:
TXID = 2.4ns
RXID = 3.62ns
Both values seems to be a bit out of spec. New values are:
TXID = PHY 0ns + MAC 2.0ns
RXID =
(rxd*-skew-ps = no change) == 0ns
(rxc-skew-ps = 1500) == +600ns
internal delay 1.2 + 600ns = 1.8ns
From the PHY point of view, it is RGMII_RXID mode. Are you sure, RGMII_ID is not working for you?
Till now the numbers was not looking as a fine tuning.
I assume, it is better to use proper phy-mode instead of skew-ps values. I feel like no one had time
to understand real configured values in this PHY.
> reg = <0>;
> interrupt-parent = <&gpio2>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
>
--
Regards,
Oleksij
next prev parent reply other threads:[~2020-06-20 5:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 19:15 [PATCH/RFC 0/5] ravb: Add support for explicit internal clock delay configuration Geert Uytterhoeven
2020-06-19 19:15 ` [PATCH/RFC 1/5] dt-bindings: net: renesas,ravb: Document internal clock delay properties Geert Uytterhoeven
2020-06-20 5:47 ` Oleksij Rempel [this message]
2020-06-20 14:43 ` Andrew Lunn
2020-06-21 8:23 ` Geert Uytterhoeven
2020-06-20 18:15 ` Sergei Shtylyov
2020-06-21 8:26 ` Geert Uytterhoeven
2020-06-19 19:15 ` [PATCH/RFC 2/5] ravb: Split delay handling in parsing and applying Geert Uytterhoeven
2020-06-20 18:34 ` Sergei Shtylyov
2020-06-19 19:15 ` [PATCH/RFC 3/5] ravb: Add support for explicit internal clock delay configuration Geert Uytterhoeven
2020-06-20 19:03 ` Sergei Shtylyov
2020-06-19 19:15 ` [PATCH/RFC 4/5] arm64: dts: renesas: rcar-gen3: Convert EtherAVB to explicit delay handling Geert Uytterhoeven
2020-06-19 19:15 ` [PATCH/RFC 5/5] arm64: dts: renesas: rzg2: " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6d0bfc5-9d75-2dc9-2bfa-671c32cb0b7c@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=kazuya.mizuguchi.ks@renesas.com \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).