From: Petr Mladek <pmladek@suse.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: lijiazi <jqqlijiazi@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
lijiazi <lijiazi@xiaomi.com>
Subject: Re: [PATCH v3 3/3] lib/vsprintf: add two device node flags
Date: Mon, 10 Feb 2020 12:42:11 +0100 [thread overview]
Message-ID: <20200210114211.ghtyu43g7c4veqdh@pathway.suse.cz> (raw)
In-Reply-To: <20200120141951.GO32742@smile.fi.intel.com>
On Mon 2020-01-20 16:19:51, Andy Shevchenko wrote:
> On Mon, Jan 20, 2020 at 07:38:29PM +0800, lijiazi wrote:
> > Add two device node flags, and use OF_DEVICE_NODE_FLAG_MAX instead
> > of sizeof("xxxx").
>
> ...
>
> > tbuf[1] = of_node_check_flag(dn, OF_DETACHED) ? 'd' : '-';
> > tbuf[2] = of_node_check_flag(dn, OF_POPULATED) ? 'P' : '-';
> > tbuf[3] = of_node_check_flag(dn, OF_POPULATED_BUS) ? 'B' : '-';
>
> > - tbuf[4] = 0;
>
> This is fine to leave untouched. See below.
>
> > + tbuf[4] = of_node_check_flag(dn, OF_OVERLAY) ? 'O' : '-';
> > + tbuf[5] = of_node_check_flag(dn, OF_OVERLAY_FREE_CSET) ? 'F' : '-';
>
> These two should be part of patch 1, which in turn should be last in the series.
>
> > + tbuf[OF_DEVICE_NODE_FLAG_MAX] = 0;
>
> This one also, but in a form of explicit number, if you afraid of problems
> here, we may add something like
I agree that explicit number would be better here:
tbuf[6] = 0;
And I like the build check. I would even check for the exact number.
It would help to keep the code updated when the number is modified.
BUILD_BUG_ON(OF_DEVICE_NODE_FLAG_MAX != 6);
Finally, I would put all three changes into the same patch. And
remove the comment above OF_DEVICE_NODE_FLAG_MAX definition
completely.
Best Regards,
Petr
next prev parent reply other threads:[~2020-02-10 11:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 11:38 [PATCH v3 1/3] lib/vsprintf: add two device node flags for %pOF lijiazi
2020-01-20 11:38 ` [PATCH v3 2/3] lib/vsprintf: introduce OF_DEVICE_NODE_FLAG_MAX lijiazi
2020-01-20 11:38 ` [PATCH v3 3/3] lib/vsprintf: add two device node flags lijiazi
2020-01-20 14:19 ` Andy Shevchenko
2020-02-10 11:42 ` Petr Mladek [this message]
2020-01-20 13:38 ` [PATCH v3 2/3] lib/vsprintf: introduce OF_DEVICE_NODE_FLAG_MAX Sergey Senozhatsky
2020-01-20 14:16 ` Andy Shevchenko
2020-01-20 13:36 ` [PATCH v3 1/3] lib/vsprintf: add two device node flags for %pOF Sergey Senozhatsky
2020-01-20 14:14 ` Andy Shevchenko
2020-01-20 14:47 ` Sergey Senozhatsky
2020-01-20 14:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210114211.ghtyu43g7c4veqdh@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jqqlijiazi@gmail.com \
--cc=lijiazi@xiaomi.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).