From: Kees Cook <keescook@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>,
Jason Yan <yanaijie@huawei.com>, Chao Yu <yuchao0@huawei.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Alexander Potapenko <glider@google.com>,
Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
x86@kernel.org, drbd-dev@lists.linbit.com,
linux-block@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-ide@vger.kernel.org,
linux-clk@vger.kernel.org, linux-spi@vger.kernel.org,
linux-mm@kvack.org, clang-built-linux@googlegroups.com
Subject: [PATCH v2 12/16] f2fs: Eliminate usage of uninitialized_var() macro
Date: Fri, 19 Jun 2020 20:30:03 -0700 [thread overview]
Message-ID: <20200620033007.1444705-13-keescook@chromium.org> (raw)
In-Reply-To: <20200620033007.1444705-1-keescook@chromium.org>
From: Jason Yan <yanaijie@huawei.com>
This is an effort to eliminate the uninitialized_var() macro[1].
The use of this macro is the wrong solution because it forces off ANY
analysis by the compiler for a given variable. It even masks "unused
variable" warnings.
Quoted from Linus[2]:
"It's a horrible thing to use, in that it adds extra cruft to the
source code, and then shuts up a compiler warning (even the _reliable_
warnings from gcc)."
Fix it by remove this variable since it is not needed at all.
[1] https://github.com/KSPP/linux/issues/81
[2] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Suggested-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Link: https://lore.kernel.org/r/20200615085132.166470-1-yanaijie@huawei.com
Signed-off-by: Kees Cook <keescook@chromium.org>
---
fs/f2fs/data.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 326c63879ddc..3753ba06531b 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -2856,7 +2856,6 @@ static int f2fs_write_cache_pages(struct address_space *mapping,
};
#endif
int nr_pages;
- pgoff_t uninitialized_var(writeback_index);
pgoff_t index;
pgoff_t end; /* Inclusive */
pgoff_t done_index;
@@ -2875,8 +2874,7 @@ static int f2fs_write_cache_pages(struct address_space *mapping,
clear_inode_flag(mapping->host, FI_HOT_DATA);
if (wbc->range_cyclic) {
- writeback_index = mapping->writeback_index; /* prev offset */
- index = writeback_index;
+ index = mapping->writeback_index; /* prev offset */
end = -1;
} else {
index = wbc->range_start >> PAGE_SHIFT;
--
2.25.1
next prev parent reply other threads:[~2020-06-20 3:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 3:29 [PATCH v2 00/16] Remove uninitialized_var() macro Kees Cook
2020-06-20 3:29 ` [PATCH v2 01/16] docs: deprecated.rst: Add uninitialized_var() Kees Cook
2020-06-22 16:59 ` Nick Desaulniers
2020-06-20 3:29 ` [PATCH v2 02/16] x86/mm/numa: Remove uninitialized_var() usage Kees Cook
2020-06-20 3:29 ` [PATCH v2 03/16] drbd: " Kees Cook
2020-06-20 3:29 ` [PATCH v2 04/16] b43: " Kees Cook
2020-06-22 17:04 ` Nick Desaulniers
2020-06-22 21:04 ` Kees Cook
2020-06-23 18:29 ` Nick Desaulniers
2020-07-15 10:37 ` Kalle Valo
2020-06-20 3:29 ` [PATCH v2 05/16] rtlwifi: rtl8192cu: " Kees Cook
2020-06-20 3:29 ` [PATCH v2 06/16] ide: " Kees Cook
2020-06-20 3:29 ` [PATCH v2 07/16] clk: st: " Kees Cook
2020-06-22 9:03 ` Stephen Boyd
2020-06-20 3:29 ` [PATCH v2 08/16] spi: davinci: " Kees Cook
2020-07-01 20:39 ` Mark Brown
2020-07-02 15:21 ` Kees Cook
2020-07-02 15:23 ` Mark Brown
2020-07-02 15:42 ` Kees Cook
2020-07-02 16:23 ` Joe Perches
2020-06-20 3:30 ` [PATCH v2 09/16] clk: spear: " Kees Cook
2020-06-22 9:03 ` Stephen Boyd
2020-06-20 3:30 ` [PATCH v2 10/16] KVM: PPC: Book3S PR: " Kees Cook
2020-06-22 17:22 ` Nick Desaulniers
2020-06-20 3:30 ` [PATCH v2 11/16] media: sur40: " Kees Cook
2020-06-22 18:39 ` Nick Desaulniers
2020-06-20 3:30 ` Kees Cook [this message]
2020-06-20 3:30 ` [PATCH v2 14/16] checkpatch: Remove awareness of uninitialized_var() macro Kees Cook
2020-06-20 3:30 ` [PATCH v2 16/16] compiler: Remove " Kees Cook
2020-06-20 3:30 ` [PATCH v2 13/16] mm/debug_vm_pgtable: Remove uninitialized_var() usage Kees Cook
2020-06-22 17:27 ` Nick Desaulniers
2020-06-20 7:03 ` [PATCH v2 00/16] Remove uninitialized_var() macro Sedat Dilek
2020-06-20 15:57 ` Kees Cook
2020-06-22 9:07 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200620033007.1444705-13-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=apw@canonical.com \
--cc=b43-dev@lists.infradead.org \
--cc=clang-built-linux@googlegroups.com \
--cc=drbd-dev@lists.linbit.com \
--cc=glider@google.com \
--cc=joe@perches.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yanaijie@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).