From: Dave Young <dyoung@redhat.com>
To: Chen Zhou <chenzhou10@huawei.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bhe@redhat.com,
catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com,
robh+dt@kernel.org, arnd@arndb.de, John.P.donnelly@oracle.com,
prabhakar.pkin@gmail.com, nsaenzjulienne@suse.de, corbet@lwn.net,
bhsharma@redhat.com, horms@verge.net.au, guohanjun@huawei.com,
xiexiuqi@huawei.com, huawei.libin@huawei.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v10 5/5] kdump: update Documentation about crashkernel on arm64
Date: Fri, 3 Jul 2020 12:46:35 +0800 [thread overview]
Message-ID: <20200703044635.GA28640@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20200703035816.31289-6-chenzhou10@huawei.com>
Hi,
Thanks for the update, but still some nitpicks :(
I'm sorry I did not catch them previously, but maybe it is not worth to
repost the whole series if no other changes needed.
On 07/03/20 at 11:58am, Chen Zhou wrote:
> Now we support crashkernel=X,[low] on arm64, update the Documentation.
> We could use parameters "crashkernel=X crashkernel=Y,low" to reserve
> memory above 4G.
>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> Tested-by: John Donnelly <John.p.donnelly@oracle.com>
> Tested-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
> ---
> Documentation/admin-guide/kdump/kdump.rst | 14 ++++++++++++--
> Documentation/admin-guide/kernel-parameters.txt | 17 +++++++++++++++--
> 2 files changed, 27 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/admin-guide/kdump/kdump.rst b/Documentation/admin-guide/kdump/kdump.rst
> index 2da65fef2a1c..e80fc9e28a9a 100644
> --- a/Documentation/admin-guide/kdump/kdump.rst
> +++ b/Documentation/admin-guide/kdump/kdump.rst
> @@ -299,7 +299,15 @@ Boot into System Kernel
> "crashkernel=64M@16M" tells the system kernel to reserve 64 MB of memory
> starting at physical address 0x01000000 (16MB) for the dump-capture kernel.
>
> - On x86 and x86_64, use "crashkernel=64M@16M".
> + On x86 use "crashkernel=64M@16M".
> +
> + On x86_64, use "crashkernel=Y" to select a region under 4G first, and
> + fall back to reserve region above 4G.
> + We can also use "crashkernel=X,high" to select a region above 4G, which
> + also tries to allocate at least 256M below 4G automatically and
> + "crashkernel=Y,low" can be used to allocate specified size low memory.
> + Use "crashkernel=Y@X" if we really have to reserve memory from specified
s/we/you
> + start address X.
>
> On ppc64, use "crashkernel=128M@32M".
>
> @@ -316,8 +324,10 @@ Boot into System Kernel
> kernel will automatically locate the crash kernel image within the
> first 512MB of RAM if X is not given.
>
> - On arm64, use "crashkernel=Y[@X]". Note that the start address of
> + On arm64, use "crashkernel=Y[@X]". Note that the start address of
> the kernel, X if explicitly specified, must be aligned to 2MiB (0x200000).
> + If crashkernel=Z,low is specified simultaneously, reserve spcified size
s/spcified/specified
> + low memory firstly and then reserve memory above 4G.
>
> Load the Dump-capture Kernel
> ============================
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index fb95fad81c79..58a731eed011 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -722,6 +722,9 @@
> [KNL, x86_64] select a region under 4G first, and
> fall back to reserve region above 4G when '@offset'
> hasn't been specified.
> + [KNL, arm64] If crashkernel=X,low is specified, reserve
> + spcified size low memory firstly, and then reserve memory
s/spcified/specified
> + above 4G.
> See Documentation/admin-guide/kdump/kdump.rst for further details.
>
> crashkernel=range1:size1[,range2:size2,...][@offset]
> @@ -746,13 +749,23 @@
> requires at least 64M+32K low memory, also enough extra
> low memory is needed to make sure DMA buffers for 32-bit
> devices won't run out. Kernel would try to allocate at
> - at least 256M below 4G automatically.
> + least 256M below 4G automatically.
> This one let user to specify own low range under 4G
> for second kernel instead.
> 0: to disable low allocation.
> It will be ignored when crashkernel=X,high is not used
> or memory reserved is below 4G.
> -
> + [KNL, arm64] range under 4G.
> + This one let user to specify own low range under 4G
s/own low/a low
> + for crash dump kernel instead.
> + Be different from x86_64, kernel reserves specified size
> + physical memory region only when this parameter is specified
> + instead of trying to reserve at least 256M below 4G
> + automatically.
> + Use this parameter along with crashkernel=X when we want
> + to reserve crashkernel above 4G. If there are devices
> + need to use ZONE_DMA in crash dump kernel, it is also
> + a good choice.
> cryptomgr.notests
> [KNL] Disable crypto self-tests
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-07-03 4:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 3:58 [PATCH v10 0/5] support reserving crashkernel above 4G on arm64 kdump Chen Zhou
2020-07-03 3:58 ` [PATCH v10 1/5] x86: kdump: move reserve_crashkernel_low() into crash_core.c Chen Zhou
2020-07-03 3:58 ` [PATCH v10 2/5] arm64: kdump: reserve crashkenel above 4G for crash dump kernel Chen Zhou
2020-07-03 3:58 ` [PATCH v10 3/5] arm64: kdump: add memory for devices by DT property linux,usable-memory-range Chen Zhou
2020-07-03 3:58 ` [PATCH v10 4/5] arm64: kdump: fix kdump broken with ZONE_DMA reintroduced Chen Zhou
2020-07-27 17:30 ` Catalin Marinas
2020-07-29 3:52 ` chenzhou
2020-07-29 11:58 ` Catalin Marinas
2020-07-29 14:14 ` chenzhou
2020-07-29 15:20 ` Catalin Marinas
2020-07-30 8:22 ` chenzhou
2020-07-03 3:58 ` [PATCH v10 5/5] kdump: update Documentation about crashkernel on arm64 Chen Zhou
2020-07-03 4:46 ` Dave Young [this message]
2020-07-03 4:50 ` Dave Young
2020-07-03 9:11 ` Dave Young
2020-07-03 7:26 ` [PATCH v10 0/5] support reserving crashkernel above 4G on arm64 kdump Bhupesh Sharma
2020-07-03 8:38 ` chenzhou
2020-07-27 12:38 ` John Donnelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703044635.GA28640@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=John.P.donnelly@oracle.com \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=chenzhou10@huawei.com \
--cc=corbet@lwn.net \
--cc=guohanjun@huawei.com \
--cc=horms@verge.net.au \
--cc=huawei.libin@huawei.com \
--cc=james.morse@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nsaenzjulienne@suse.de \
--cc=prabhakar.pkin@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).