From: Ram Pai <linuxram@us.ibm.com>
To: Bharata B Rao <bharata@linux.ibm.com>
Cc: Julia Lawall <julia.lawall@inria.fr>,
sukadev@linux.ibm.com, corbet@lwn.net, linux-doc@vger.kernel.org,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
paulus@ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org,
ldufour@linux.ibm.com, david@gibson.dropbear.id.au,
sathnaga@linux.vnet.ibm.com
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Define H_PAGE_IN_NONSHARED for H_SVM_PAGE_IN hcall
Date: Fri, 31 Jul 2020 01:10:44 -0700 [thread overview]
Message-ID: <20200731081044.GA5787@oc0525413822.ibm.com> (raw)
In-Reply-To: <20200731043334.GB20199@in.ibm.com>
On Fri, Jul 31, 2020 at 10:03:34AM +0530, Bharata B Rao wrote:
> On Thu, Jul 30, 2020 at 04:21:01PM -0700, Ram Pai wrote:
> > H_SVM_PAGE_IN hcall takes a flag parameter. This parameter specifies the
> > way in which a page will be treated. H_PAGE_IN_NONSHARED indicates
> > that the page will be shared with the Secure VM, and H_PAGE_IN_SHARED
> > indicates that the page will not be shared but its contents will
> > be copied.
>
> Looks like you got the definitions of shared and non-shared interchanged.
Yes. Realized it after sending the patch. Will fix it.
>
> >
> > However H_PAGE_IN_NONSHARED is not defined in the header file, though
> > it is defined and documented in the API captured in
> > Documentation/powerpc/ultravisor.rst
> >
> > Define H_PAGE_IN_NONSHARED in the header file.
>
> What is the use of defining this? Is this used directly in any place?
> Or, are youp planning to introduce such a usage?
I know the Hypervisor code currently has no use for that define.
It assumes H_PAGE_IN_NONSHARED to be !H_PAGE_IN_SHARED.
But H_PAGE_IN_NONSHARED is defined in the Ultravisor API, and hence has
to be captured in the header, to stay consistent.
RP
prev parent reply other threads:[~2020-07-31 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:35 Documentation/powerpc: Ultravisor API Julia Lawall
2020-07-30 16:48 ` Ram Pai
2020-07-30 23:21 ` [PATCH] KVM: PPC: Book3S HV: Define H_PAGE_IN_NONSHARED for H_SVM_PAGE_IN hcall Ram Pai
2020-07-31 4:33 ` Bharata B Rao
2020-07-31 8:10 ` Ram Pai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731081044.GA5787@oc0525413822.ibm.com \
--to=linuxram@us.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bharata@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=david@gibson.dropbear.id.au \
--cc=julia.lawall@inria.fr \
--cc=kvm-ppc@vger.kernel.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=sathnaga@linux.vnet.ibm.com \
--cc=sukadev@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).