From: Matthew Wilcox <willy@infradead.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"Dafna Hirschfeld" <dafna.hirschfeld@collabora.com>,
"Nícolas F. R. A. Prado" <nfraprado@protonmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
lkcamp@lists.libreplanetbr.org, andrealmeid@collabora.com
Subject: Re: Python 2.7 support and automarkup.py - Was: Re: [PATCH v2 1/5] docs: automarkup.py: Use new C roles in Sphinx 3
Date: Fri, 30 Oct 2020 14:39:37 +0000 [thread overview]
Message-ID: <20201030143937.GK27442@casper.infradead.org> (raw)
In-Reply-To: <20201030081440.47a74dad@lwn.net>
On Fri, Oct 30, 2020 at 08:14:40AM -0600, Jonathan Corbet wrote:
> On Fri, 30 Oct 2020 15:10:26 +0100
> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
>
> > I see a few alternatives:
> >
> > 1) fix automarkup.py for it to work again with python 2.7;
> >
> > 2) conf.py could gain some logic to disable automarkup with
> > Python < 3;
> >
> > 3) scripts/sphinx-pre-install already detects Python version.
> > It should likely be easy to ask the user to use python 3.x,
> > if an older version is detected.
> >
> > Doing (1) or (2) will require an additional step when we raise
> > the bar for Python version.
>
> We haven't dropped support for Python 2 yet, so this constitutes a
> regression. My own approach would be something like this at the top of
> automarkup.py:
>
> if python2:
> ascii = 0
> else:
> ascii = re.ASCII
>
> ...then s/re.ASCII/ascii/ throughout. I can probably put together
> something later this morning.
Could we have a warning somewhere that python 2.7 is going to produce
inferior docs?
Alternatively, https://docs.python.org/2/library/re.html suggests
using "The third-party regex module".
next prev parent reply other threads:[~2020-10-30 14:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 23:13 [PATCH v2 0/5] docs: automarkup.py: Make automarkup ready for Sphinx 3.1+ Nícolas F. R. A. Prado
2020-10-13 23:13 ` [PATCH v2 1/5] docs: automarkup.py: Use new C roles in Sphinx 3 Nícolas F. R. A. Prado
2020-10-30 13:33 ` Dafna Hirschfeld
2020-10-30 14:00 ` Jonathan Corbet
2020-10-30 14:10 ` Python 2.7 support and automarkup.py - Was: " Mauro Carvalho Chehab
2020-10-30 14:14 ` Jonathan Corbet
2020-10-30 14:15 ` Mauro Carvalho Chehab
2020-10-30 14:39 ` Matthew Wilcox [this message]
2020-10-13 23:13 ` [PATCH v2 2/5] docs: automarkup.py: Fix regexes to solve sphinx 3 warnings Nícolas F. R. A. Prado
2020-10-14 19:11 ` Jonathan Corbet
2020-10-13 23:13 ` [PATCH v2 3/5] docs: automarkup.py: Skip C reserved words when cross-referencing Nícolas F. R. A. Prado
2020-10-13 23:13 ` [PATCH v2 4/5] docs: automarkup.py: Add cross-reference for parametrized C macros Nícolas F. R. A. Prado
2020-10-13 23:13 ` [PATCH v2 5/5] docs: automarkup.py: Allow automatic cross-reference inside C namespace Nícolas F. R. A. Prado
2020-10-14 9:56 ` Mauro Carvalho Chehab
2020-10-14 19:19 ` Jonathan Corbet
2020-11-02 15:33 ` Nícolas F. R. A. Prado
2020-10-30 15:07 Python 2.7 support and automarkup.py - Was: Re: [PATCH v2 1/5] docs: automarkup.py: Use new C roles in Sphinx 3 Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030143937.GK27442@casper.infradead.org \
--to=willy@infradead.org \
--cc=andrealmeid@collabora.com \
--cc=corbet@lwn.net \
--cc=dafna.hirschfeld@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=mchehab+huawei@kernel.org \
--cc=nfraprado@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).