From: kernel test robot <lkp@intel.com>
To: Luiz Sampaio <sampaio.ime@gmail.com>, zbr@ioremap.net
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
corbet@lwn.net, rikard.falkeborn@gmail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Luiz Sampaio <sampaio.ime@gmail.com>
Subject: Re: [PATCH v6 3/6] w1: ds2438: fixed a coding style issue
Date: Fri, 9 Apr 2021 17:44:08 +0800 [thread overview]
Message-ID: <202104091730.0iAaaZ3t-lkp@intel.com> (raw)
In-Reply-To: <20210409031533.442123-4-sampaio.ime@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3065 bytes --]
Hi Luiz,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.12-rc6 next-20210408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Luiz-Sampaio/w1-ds2438-fixed-a-coding-style-issue/20210409-121608
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 17e7124aad766b3f158943acb51467f86220afe9
config: x86_64-randconfig-a004-20210409 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project dd453a1389b6a7e6d9214b449d3c54981b1a89b6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/3ca70e59a342a9c6fd7db0bc937bbd0c80da9711
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Luiz-Sampaio/w1-ds2438-fixed-a-coding-style-issue/20210409-121608
git checkout 3ca70e59a342a9c6fd7db0bc937bbd0c80da9711
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/w1/slaves/w1_ds2438.c:391:31: error: too many arguments provided to function-like macro invocation
static BIN_ATTR_RW(iad, 0664, iad_write, 0);
^
include/linux/sysfs.h:229:9: note: macro 'BIN_ATTR_RW' defined here
#define BIN_ATTR_RW(_name, _size) \
^
drivers/w1/slaves/w1_ds2438.c:398:3: error: use of undeclared identifier 'bin_attr_iad'; did you mean 'bin_attr_vad'?
&bin_attr_iad,
^~~~~~~~~~~~
bin_attr_vad
drivers/w1/slaves/w1_ds2438.c:394:8: note: 'bin_attr_vad' declared here
static BIN_ATTR_RO(vad, 0/* real length varies */);
^
include/linux/sysfs.h:224:22: note: expanded from macro 'BIN_ATTR_RO'
struct bin_attribute bin_attr_##_name = __BIN_ATTR_RO(_name, _size)
^
<scratch space>:113:1: note: expanded from here
bin_attr_vad
^
2 errors generated.
vim +391 drivers/w1/slaves/w1_ds2438.c
390
> 391 static BIN_ATTR_RW(iad, 0664, iad_write, 0);
392 static BIN_ATTR_RO(page0, DS2438_PAGE_SIZE);
393 static BIN_ATTR_RO(temperature, 0/* real length varies */);
394 static BIN_ATTR_RO(vad, 0/* real length varies */);
395 static BIN_ATTR_RO(vdd, 0/* real length varies */);
396
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34309 bytes --]
next prev parent reply other threads:[~2021-04-09 9:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210405105009.420924-1-sampaio.ime@gmail.com>
2021-04-09 3:09 ` [PATCH v5 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-04-09 4:39 ` Joe Perches
2021-04-09 14:40 ` Joe Perches
2021-04-16 22:26 ` Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 3/6] w1: ds2438: fixed a " Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-09 3:09 ` [PATCH v5 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 0/9] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 3/6] w1: ds2438: fixed a " Luiz Sampaio
2021-04-09 9:44 ` kernel test robot [this message]
2021-04-09 10:43 ` kernel test robot
2021-04-10 8:38 ` Greg KH
2021-04-09 3:15 ` [PATCH v6 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-09 3:15 ` [PATCH v6 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 3/6] w1: ds2438: changed sysfs macro for rw file Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-04-16 22:17 ` [PATCH v7 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
2021-04-17 5:25 ` kernel test robot
2021-05-14 11:47 ` [PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements Greg KH
2021-05-19 22:30 ` [PATCH v8 " Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 1/6] w1: ds2438: fixed a coding style issue Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 2/6] w1: ds2438: fixed if brackets " Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 3/6] w1: ds2438: changed sysfs macro for rw file Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 4/6] w1: ds2438: fixing bug that would always get page0 Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 5/6] w1: ds2438: adding support for reading page1 Luiz Sampaio
2021-05-19 22:30 ` [PATCH v8 6/6] w1: ds2438: support for writing to offset register Luiz Sampaio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104091730.0iAaaZ3t-lkp@intel.com \
--to=lkp@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=sampaio.ime@gmail.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).