From: Thomas Zimmermann <tzimmermann@suse.de>
To: Maxime Ripard <maxime@cerno.tech>
Cc: daniel@ffwll.ch, airlied@linux.ie,
maarten.lankhorst@linux.intel.com, kraxel@redhat.com,
corbet@lwn.net, lgirdwood@gmail.com, broonie@kernel.org,
sam@ravnborg.org, robh@kernel.org, emil.l.velikov@gmail.com,
geert+renesas@glider.be, hdegoede@redhat.com,
bluescreen_avenger@verizon.net, dri-devel@lists.freedesktop.org,
linux-doc@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 08/10] drm/simpledrm: Acquire clocks from DT device node
Date: Thu, 15 Apr 2021 09:31:01 +0200 [thread overview]
Message-ID: <3c7bacd1-e40e-0953-9ad9-9f79274106d5@suse.de> (raw)
In-Reply-To: <20210408081353.ojt2kgnnbh6kp6gp@gilmour>
[-- Attachment #1.1: Type: text/plain, Size: 1385 bytes --]
Hi
Am 08.04.21 um 10:13 schrieb Maxime Ripard:
> Hi,
>
> On Thu, Mar 18, 2021 at 11:29:19AM +0100, Thomas Zimmermann wrote:
>> Make sure required hardware clocks are enabled while the firmware
>> framebuffer is in use.
>>
>> The basic code has been taken from the simplefb driver and adapted
>> to DRM. Clocks are released automatically via devres helpers.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Tested-by: nerdopolis <bluescreen_avenger@verizon.net>
>
> Even though it's definitely simpler to review, merging the driver first
> and then the clocks and regulators will break bisection on the platforms
> that rely on them
I'd like to keep the patches separate for now, but can squash patches 6
to 8 them into one before pushing them. OK?
>
> Another thing worth considering is also that both drivers will probe if
> they are enabled (which is pretty likely), which is not great :)
>
> I guess we should make them mutually exclusive through Kconfig
We already have several drivers in fbdev and DRM that handle the same
hardware. We don't do this for any other pair, why bother now?
Best regards
Thomas
>
> Maxime
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-04-15 7:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 10:29 [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 01/10] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip() Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 02/10] drm/format-helper: Add blitter functions Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 03/10] drm/aperture: Move fbdev conflict helpers into drm_aperture.h Thomas Zimmermann
2021-04-08 9:50 ` Daniel Vetter
2021-04-09 7:09 ` Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 04/10] drm/aperture: Add infrastructure for aperture ownership Thomas Zimmermann
2021-04-08 9:48 ` Daniel Vetter
2021-04-09 7:06 ` Thomas Zimmermann
2021-04-09 9:22 ` Daniel Vetter
2021-04-15 6:56 ` Thomas Zimmermann
2021-04-15 12:57 ` Daniel Vetter
2021-04-15 19:12 ` Thomas Zimmermann
2021-04-16 8:42 ` Daniel Vetter
2021-04-09 7:54 ` Thomas Zimmermann
2021-04-09 9:29 ` Daniel Vetter
2021-03-18 10:29 ` [PATCH v2 05/10] drm: Add simpledrm driver Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 06/10] drm/simpledrm: Add fbdev emulation Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 07/10] drm/simpledrm: Initialize framebuffer data from device-tree node Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 08/10] drm/simpledrm: Acquire clocks from DT device node Thomas Zimmermann
2021-03-18 10:39 ` Geert Uytterhoeven
2021-03-18 11:00 ` Thomas Zimmermann
2021-04-08 8:13 ` Maxime Ripard
2021-04-15 7:31 ` Thomas Zimmermann [this message]
2021-04-15 9:21 ` Maxime Ripard
2021-04-15 11:02 ` Thomas Zimmermann
2021-04-15 12:11 ` maxime
2021-03-18 10:29 ` [PATCH v2 09/10] drm/simpledrm: Acquire regulators " Thomas Zimmermann
2021-03-18 10:29 ` [PATCH v2 10/10] drm/simpledrm: Acquire memory aperture for framebuffer Thomas Zimmermann
2021-03-25 11:29 ` [PATCH v2 00/10] drm: Support simple-framebuffer devices and firmware fbs Hans de Goede
2021-03-29 12:31 ` Thomas Zimmermann
2021-03-29 14:50 ` Hans de Goede
2021-03-30 7:09 ` Thomas Zimmermann
2021-03-30 8:34 ` Hans de Goede
2021-04-08 10:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c7bacd1-e40e-0953-9ad9-9f79274106d5@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=bluescreen_avenger@verizon.net \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hdegoede@redhat.com \
--cc=kraxel@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).