From: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org, mcgrof@kernel.org, yzaikin@google.com,
tglx@linutronix.de, kernel@gpiccoli.net
Subject: Re: [PATCH] kernel/hung_task.c: Introduce sysctl to print all traces when a hung task is detected
Date: Mon, 16 Mar 2020 11:01:34 -0300 [thread overview]
Message-ID: <627a34c6-6ccd-d6c9-ae91-fd7cb4087e96@canonical.com> (raw)
In-Reply-To: <c4b05b32-216a-e130-259f-0d9506ff9244@i-love.sakura.ne.jp>
On 14/03/2020 01:27, Tetsuo Handa wrote:
> On 2020/03/14 12:12, Kees Cook wrote:
>> On Fri, Mar 13, 2020 at 02:23:37PM -0300, Guilherme G. Piccoli wrote:
>>> Kees / Testsuo, are you OK with this patch once I resend with the
>>> suggestions you gave me?
>>
>> I think so, yes. Send a v2 (to akpm with us in CC).
>>
>>> Is there anybody else I should loop in the patch that should take a
>>> look? Never sent sysctl stuff before, sorry if I forgot somebody heheh
>>
>> akpm usually takes these kinds of things.
>>
>
> Well, maybe sysctl_hung_task_all_cpu_backtrace = 1 by default is better for
> compatibility? Please CC or BCC kernel-testing people so that they can add
> hung_task_all_cpu_backtrace=1 kernel command line parameter to their testing
> environments if sysctl_hung_task_all_cpu_backtrace = 0 by default.
>
Thanks a lot Kees and Tetsuo, I'll implement the suggestions and loop
the kernel-testing and akpm in V2.
About being default, I personally think it's better / more reasonable to
have this parameter defaults to 0, to keep consistency with all other
*_all_cpu_backtrace parameters. Right now kernel shows the backtraces
only when hung_task_panic is set, so the idea of this patch is to
decouple the toggles and allow the user to decide about this policy.
Nevertheless, if people consider that would be good to have it as
enabled by default, I can change it in a potential V3.
Cheers,
Guilherme
prev parent reply other threads:[~2020-03-16 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 15:56 [PATCH] kernel/hung_task.c: Introduce sysctl to print all traces when a hung task is detected Guilherme G. Piccoli
2020-03-10 16:05 ` Kees Cook
2020-03-13 17:23 ` Guilherme G. Piccoli
2020-03-14 3:12 ` Kees Cook
2020-03-14 4:27 ` Tetsuo Handa
2020-03-16 14:01 ` Guilherme G. Piccoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=627a34c6-6ccd-d6c9-ae91-fd7cb4087e96@canonical.com \
--to=gpiccoli@canonical.com \
--cc=keescook@chromium.org \
--cc=kernel@gpiccoli.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=tglx@linutronix.de \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).