From: Peter Rosin <peda@axentia.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jonathan Corbet <corbet@lwn.net>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v3 3/3] fbdev: fbmem: avoid exporting fb_center_logo
Date: Thu, 29 Aug 2019 07:08:26 +0000 [thread overview]
Message-ID: <6cb5ec1b-ae60-5ca4-f0d9-1414f52fed73@axentia.se> (raw)
In-Reply-To: <CAMuHMdVkqX7x_D5nf01s-kE=o+y5OLM-5fd3q=2RDKGTcpCfHg@mail.gmail.com>
On 2019-08-27 13:35, Geert Uytterhoeven wrote:
> Hi Peter,
>
> On Tue, Aug 27, 2019 at 1:09 PM Peter Rosin <peda@axentia.se> wrote:
>> The variable is only ever used from fbcon.c which is linked into the
>> same module. Therefore, the export is not needed.
>>
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> But note that the same is true for fb_class, so perhaps it can be added
> (or better, removed ;-)?
Right. Someone please let me know if 3/3 needs to be extended. I'm also
happy to just drop it...
> Once drivers/staging/olpc_dcon/olpc_dcon.c stops abusing registered_fb[]
> and num_registered_fb, those can go, too.
>
> Does anyone remembe why au1200fb calls fb_prepare_logo() and fb_show_logo()
> itself?
Maybe there should be a small drivers/video/fbdev/core/fbmem.h file (or
something) with these "internal" declarations, to hide some clutter currently
in include/linux/fb.h?
Feels like that could be done later, after these other cleanups you mention,
so that the new file has a few more things to declare.
Cheers,
Peter
next prev parent reply other threads:[~2019-08-29 7:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 11:09 [PATCH v3 0/3] Add possibility to specify the number of displayed logos Peter Rosin
2019-08-27 11:09 ` [PATCH v3 1/3] fbdev: fix numbering of fbcon options Peter Rosin
2019-08-27 11:25 ` Geert Uytterhoeven
2020-01-03 11:51 ` Bartlomiej Zolnierkiewicz
2019-08-27 11:09 ` [PATCH v3 2/3] fbdev: fbmem: allow overriding the number of bootup logos Peter Rosin
2019-08-27 11:25 ` Geert Uytterhoeven
2020-01-03 11:52 ` Bartlomiej Zolnierkiewicz
2019-08-27 11:09 ` [PATCH v3 3/3] fbdev: fbmem: avoid exporting fb_center_logo Peter Rosin
2019-08-27 11:35 ` Geert Uytterhoeven
2019-08-29 7:08 ` Peter Rosin [this message]
2020-01-03 11:55 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cb5ec1b-ae60-5ca4-f0d9-1414f52fed73@axentia.se \
--to=peda@axentia.se \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).