From: Sedat Dilek <sedat.dilek@gmail.com>
To: Bill Wendling <morbo@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
Clang-Built-Linux ML <clang-built-linux@googlegroups.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure
Date: Thu, 21 Jan 2021 03:21:43 +0100 [thread overview]
Message-ID: <CA+icZUW63tP7kzWCKofJH0E0xA7yLCYpSOYz_aw1D4mkhNhW=w@mail.gmail.com> (raw)
In-Reply-To: <20210111081821.3041587-1-morbo@google.com>
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
Hi,
When I looked through the code I wondered why we do not add a
"CONFIG_PGO_CLANG_PROFDATA" which can be helpful when doing the PGO
rebuild with a vmlinux.profdata.
This introduces a "PGO_PROFDATA" to turn on/off to pass
"-fprofile-use=vmlinux.profdata" (see CFLAGS_PGO_CLANG_PROFDATA in
top-level Makefile).
If we turn off via "PGO_PROFILE := n" in several Makefiles - we should
do the same and add "PGO_PROFDATA := n" to the same Makefiles?
Please see the attached diff.
Regards,
- Sedat -
[-- Attachment #2: CONFIG_PGO_CLANG_PROFDATA.diff --]
[-- Type: text/x-patch, Size: 4769 bytes --]
diff --git a/Makefile b/Makefile
index dd58fca65c9f..d9a48279c4d5 100644
--- a/Makefile
+++ b/Makefile
@@ -660,7 +660,8 @@ endif # KBUILD_EXTMOD
all: vmlinux
CFLAGS_PGO_CLANG := -fprofile-generate
-export CFLAGS_PGO_CLANG
+CFLAGS_PGO_CLANG_PROFDATA := -fprofile-use=vmlinux.profdata
+export CFLAGS_PGO_CLANG CFLAGS_PGO_CLANG_PROFDATA
CFLAGS_GCOV := -fprofile-arcs -ftest-coverage \
$(call cc-option,-fno-tree-loop-im) \
diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile
index 383853e32f67..3268d1ee6e45 100644
--- a/arch/x86/boot/Makefile
+++ b/arch/x86/boot/Makefile
@@ -72,6 +72,7 @@ KBUILD_CFLAGS += $(call cc-option,-fmacro-prefix-map=$(srctree)/=)
KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
GCOV_PROFILE := n
PGO_PROFILE := n
+PGO_PROFDATA := n
UBSAN_SANITIZE := n
$(obj)/bzImage: asflags-y := $(SVGA_MODE)
diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
index ed12ab65f606..707c4034aef7 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile
@@ -55,6 +55,7 @@ CFLAGS_sev-es.o += -I$(objtree)/arch/x86/lib/
KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
GCOV_PROFILE := n
PGO_PROFILE := n
+PGO_PROFDATA := n
UBSAN_SANITIZE :=n
KBUILD_LDFLAGS := -m elf_$(UTS_MACHINE)
diff --git a/arch/x86/crypto/Makefile b/arch/x86/crypto/Makefile
index baa14f83edae..1b2cb9142672 100644
--- a/arch/x86/crypto/Makefile
+++ b/arch/x86/crypto/Makefile
@@ -5,6 +5,7 @@
OBJECT_FILES_NON_STANDARD := y
PGO_PROFILE_curve25519-x86_64.o := n
+PGO_PROFDATA_curve25519-x86_64.o := n
obj-$(CONFIG_CRYPTO_TWOFISH_586) += twofish-i586.o
twofish-i586-y := twofish-i586-asm_32.o twofish_glue.o
diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
index f7421e44725a..67860ecde542 100644
--- a/arch/x86/entry/vdso/Makefile
+++ b/arch/x86/entry/vdso/Makefile
@@ -181,6 +181,7 @@ VDSO_LDFLAGS = -shared --hash-style=both --build-id=sha1 \
$(call ld-option, --eh-frame-hdr) -Bsymbolic
GCOV_PROFILE := n
PGO_PROFILE := n
+PGO_PROFDATA := n
quiet_cmd_vdso_and_check = VDSO $@
cmd_vdso_and_check = $(cmd_vdso); $(cmd_vdso_check)
diff --git a/arch/x86/platform/efi/Makefile b/arch/x86/platform/efi/Makefile
index 5f22b31446ad..5d64b728a0a0 100644
--- a/arch/x86/platform/efi/Makefile
+++ b/arch/x86/platform/efi/Makefile
@@ -3,6 +3,7 @@ OBJECT_FILES_NON_STANDARD_efi_thunk_$(BITS).o := y
KASAN_SANITIZE := n
GCOV_PROFILE := n
PGO_PROFILE := n
+PGO_PROFDATA := n
obj-$(CONFIG_EFI) += quirks.o efi.o efi_$(BITS).o efi_stub_$(BITS).o
obj-$(CONFIG_EFI_MIXED) += efi_thunk_$(BITS).o
diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile
index 36f20e99da0b..99f2e4c1886e 100644
--- a/arch/x86/purgatory/Makefile
+++ b/arch/x86/purgatory/Makefile
@@ -24,6 +24,7 @@ targets += purgatory.ro purgatory.chk
# Sanitizer, etc. runtimes are unavailable and cannot be linked here.
GCOV_PROFILE := n
PGO_PROFILE := n
+PGO_PROFDATA := n
KASAN_SANITIZE := n
UBSAN_SANITIZE := n
KCSAN_SANITIZE := n
diff --git a/arch/x86/realmode/rm/Makefile b/arch/x86/realmode/rm/Makefile
index 21797192f958..a495890e9b11 100644
--- a/arch/x86/realmode/rm/Makefile
+++ b/arch/x86/realmode/rm/Makefile
@@ -77,4 +77,5 @@ KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__
KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
GCOV_PROFILE := n
PGO_PROFILE := n
+PGO_PROFDATA := n
UBSAN_SANITIZE := n
diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile
index 54f5768f5853..2e9cdc137ade 100644
--- a/arch/x86/um/vdso/Makefile
+++ b/arch/x86/um/vdso/Makefile
@@ -65,6 +65,7 @@ quiet_cmd_vdso = VDSO $@
VDSO_LDFLAGS = -fPIC -shared -Wl,--hash-style=sysv
GCOV_PROFILE := n
PGO_PROFILE := n
+PGO_PROFDATA := n
#
# Install the unstripped copy of vdso*.so listed in $(vdso-install-y).
diff --git a/kernel/pgo/Kconfig b/kernel/pgo/Kconfig
index 5fe9635ac64c..ce1e1c061a98 100644
--- a/kernel/pgo/Kconfig
+++ b/kernel/pgo/Kconfig
@@ -32,4 +32,8 @@ config PGO_CLANG
Note that the debugfs filesystem has to be mounted to access
profiling data.
+config PGO_CLANG_PROFDATA
+ bool "Use vmlinux.profdata profile file"
+ depends on !PGO_CLANG
+
endmenu
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 12fed825ab4b..14169a575b64 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -154,6 +154,12 @@ _c_flags += $(if $(patsubst n%,, \
$(PGO_PROFILE_$(basetarget).o)$(PGO_PROFILE)y), \
$(CFLAGS_PGO_CLANG))
endif
+# Use vmlinux.profdata profile file
+ifeq ($(CONFIG_PGO_CLANG_PROFDATA),y)
+_c_flags += $(if $(patsubst n%,, \
+ $(PGO_PROFDATA_$(basetarget).o)$(PGO_PROFDATA)y), \
+ $(CFLAGS_PGO_CLANG_PROFDATA))
+endif
#
# Enable address sanitizer flags for kernel except some files or directories
next prev parent reply other threads:[~2021-01-21 3:37 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 8:18 [PATCH] pgo: add clang's Profile Guided Optimization infrastructure Bill Wendling
2021-01-11 8:39 ` Sedat Dilek
2021-01-11 8:42 ` Sedat Dilek
2021-01-11 9:17 ` Bill Wendling
2021-01-11 9:57 ` Sedat Dilek
2021-01-11 18:28 ` Nathan Chancellor
2021-01-11 20:12 ` Fangrui Song
2021-01-11 20:23 ` Bill Wendling
2021-01-11 20:31 ` Fangrui Song
2021-01-12 0:37 ` Bill Wendling
2021-01-12 0:44 ` Fāng-ruì Sòng
2021-01-11 21:04 ` Nathan Chancellor
2021-01-11 21:17 ` Nick Desaulniers
2021-01-11 21:32 ` Bill Wendling
2021-01-12 5:14 ` [PATCH v2] " Bill Wendling
2021-01-12 5:17 ` Sedat Dilek
2021-01-12 5:31 ` [PATCH v3] " Bill Wendling
[not found] ` <202101121755.pyYoRozB-lkp@intel.com>
2021-01-12 17:22 ` Nathan Chancellor
2021-01-13 6:19 ` [PATCH v4] " Bill Wendling
2021-01-13 20:55 ` Nathan Chancellor
2021-01-13 21:59 ` Bill Wendling
2021-01-14 4:07 ` Nick Desaulniers
2021-01-16 0:01 ` Nick Desaulniers
2021-01-16 0:13 ` Nick Desaulniers
2021-01-16 4:30 ` Sedat Dilek
2021-01-16 5:07 ` Sedat Dilek
2021-01-16 5:18 ` Sedat Dilek
2021-01-18 0:57 ` Sedat Dilek
2021-01-13 23:01 ` Nick Desaulniers
2021-01-16 9:43 ` [PATCH v5] " Bill Wendling
2021-01-16 17:38 ` Sedat Dilek
2021-01-16 18:36 ` Sedat Dilek
2021-01-16 20:23 ` Bill Wendling
2021-01-17 10:44 ` Sedat Dilek
2021-01-17 10:53 ` Sedat Dilek
2021-01-17 11:23 ` Sedat Dilek
2021-01-17 11:42 ` Sedat Dilek
2021-01-17 11:58 ` Sedat Dilek
[not found] ` <CA+icZUXmn15w=kSq2CZzQD5JggJw_9AEam=Sz13M0KpJ68MWZg@mail.gmail.com>
2021-01-17 17:42 ` Sedat Dilek
2021-01-17 20:34 ` Bill Wendling
[not found] ` <CA+icZUU1HihUFaEHzF69+01+Picg8aq6HAqHupxiRqyDGJ=Mpw@mail.gmail.com>
[not found] ` <CA+icZUUuzA5JEXyVzKbVX+T3xeOdRAU6-mntbo+VwwTxqmN7LA@mail.gmail.com>
2021-01-18 2:32 ` Bill Wendling
2021-01-18 12:39 ` Sedat Dilek
2021-01-18 17:26 ` Sedat Dilek
2021-01-18 21:56 ` Bill Wendling
2021-01-18 23:29 ` Sedat Dilek
2021-01-21 2:03 ` Sedat Dilek
2021-01-21 22:44 ` Sedat Dilek
2021-01-22 1:42 ` Nick Desaulniers
2021-01-22 1:49 ` Sedat Dilek
2021-01-22 1:52 ` Nick Desaulniers
2021-01-20 1:02 ` Nick Desaulniers
2021-01-21 0:51 ` Nick Desaulniers
2021-01-21 8:24 ` Bill Wendling
2021-01-21 8:24 ` [PATCH v6] " Bill Wendling
2021-01-21 10:34 ` Sedat Dilek
2021-01-22 1:44 ` Nick Desaulniers
2021-01-22 1:51 ` Sedat Dilek
2021-01-22 0:14 ` Sedat Dilek
2021-01-22 0:58 ` Sedat Dilek
2021-01-22 1:29 ` Nick Desaulniers
2021-01-22 10:11 ` [PATCH v7] " Bill Wendling
2021-01-22 11:31 ` Sedat Dilek
2021-01-22 18:41 ` Nick Desaulniers
[not found] ` <CA+icZUU=XfwqMcXYonQKcD4QgqTBW-mA+d_84b7cU2R3HYPOSQ@mail.gmail.com>
2021-01-28 21:12 ` Nick Desaulniers
2021-01-28 21:19 ` Sedat Dilek
2021-01-28 21:24 ` Nick Desaulniers
2021-01-28 21:39 ` Sedat Dilek
2021-01-29 7:43 ` Sedat Dilek
2021-01-29 21:48 ` Nick Desaulniers
2021-02-10 23:25 ` Bill Wendling
2021-02-22 21:52 ` Bill Wendling
2021-02-26 22:20 ` [PATCH v8] " Bill Wendling
2021-02-26 22:55 ` Bill Wendling
2021-02-28 18:52 ` Fangrui Song
2021-02-28 21:50 ` Fangrui Song
2021-01-12 17:37 ` [PATCH v2] " Nick Desaulniers
2021-01-12 17:45 ` Fāng-ruì Sòng
2021-01-21 2:21 ` Sedat Dilek [this message]
2021-01-22 1:34 ` [PATCH] " Nick Desaulniers
2021-01-22 1:43 ` Sedat Dilek
2021-04-07 21:17 ` [PATCH v9] " Bill Wendling
2021-04-07 21:22 ` Kees Cook
2021-04-07 21:44 ` Fāng-ruì Sòng
2021-04-07 21:47 ` Nathan Chancellor
2021-04-07 21:58 ` Bill Wendling
2021-05-19 21:37 ` Kees Cook
2021-05-22 23:51 ` Bill Wendling
2021-05-31 21:12 ` Nathan Chancellor
2021-06-01 17:31 ` Nick Desaulniers
2021-06-12 16:59 ` Peter Zijlstra
2021-06-12 17:25 ` Bill Wendling
2021-06-12 18:15 ` Peter Zijlstra
2021-06-12 19:10 ` Bill Wendling
2021-06-12 19:28 ` Bill Wendling
2021-06-12 20:25 ` Peter Zijlstra
2021-06-12 20:56 ` Bill Wendling
2021-06-12 22:47 ` Bill Wendling
2021-06-13 18:07 ` Bill Wendling
2021-06-14 9:43 ` Peter Zijlstra
2021-06-14 10:18 ` Peter Zijlstra
2021-06-14 7:51 ` Peter Zijlstra
2021-06-14 9:01 ` Peter Zijlstra
2021-06-14 9:39 ` Bill Wendling
2021-06-14 10:44 ` Peter Zijlstra
2021-06-14 11:41 ` Bill Wendling
2021-06-14 11:43 ` Bill Wendling
2021-06-14 14:16 ` Marco Elver
2021-06-14 15:26 ` Kees Cook
2021-06-14 15:35 ` Peter Zijlstra
2021-06-14 16:22 ` Kees Cook
2021-06-14 18:07 ` Nick Desaulniers
2021-06-14 20:49 ` Nick Desaulniers
2021-06-14 15:46 ` Peter Zijlstra
2021-06-14 16:03 ` Nick Desaulniers
2021-06-12 20:20 ` Fangrui Song
2021-06-12 20:31 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+icZUW63tP7kzWCKofJH0E0xA7yLCYpSOYz_aw1D4mkhNhW=w@mail.gmail.com' \
--to=sedat.dilek@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).