From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C60C433E6 for ; Wed, 10 Feb 2021 19:15:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE4D864E7A for ; Wed, 10 Feb 2021 19:15:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234551AbhBJTOu (ORCPT ); Wed, 10 Feb 2021 14:14:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234541AbhBJTOg (ORCPT ); Wed, 10 Feb 2021 14:14:36 -0500 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4EC8C06174A for ; Wed, 10 Feb 2021 11:13:56 -0800 (PST) Received: by mail-yb1-xb36.google.com with SMTP id p193so3135763yba.4 for ; Wed, 10 Feb 2021 11:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9tOqcLFPGtBJA35TM92FKNxWnaOl6vWWHEx3bmxeU4c=; b=XFODFH/7aQvtIfr1O4SP9Wqe5MlKRy2+5dSSHkXHfVH+R+9OU/TOZ09pDYnsl2vv6f 7cEH0Z6UoELRKGzsUtNvmrtDQBC7r/G6Qbtc6/JSVfpXccP4PLau8NMeL9A/OubRwHB1 VcQgYnA99MaEy+19EMwjObrtrLHqOsWNZCG7glqOH4z70X5XE+yqXhvDlsdiAQ/u3YSN Knm1TcpqnE53hNrSXGIaZ1BOedUnzxDSf5jrLpOiLeIOK5pwSMexOYyGY2xjXBi3ngV8 8z+ArJgCyMQcwrbbGYQ++ExEvF/KSID9fcTT6i+zsJoDK7PfrUfv724oQwAHLyzfxRpH jSMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9tOqcLFPGtBJA35TM92FKNxWnaOl6vWWHEx3bmxeU4c=; b=fCfOEBoAqXDdYO4SlJk60bWaB6L1F+VE9qeW9JwEfhju9sinvom+7aIK4zi2xdQI4P 5OvrQJbtkWjARi4lAoex8KmMZlyG8dAdIk1t5UmhdMX30s7o2SSZ0PuQbyqa01daWFqG nJnXxYlDDK3wA7yCsNLjwmLo5621eorjKch55/LBlT4iFVtCeg9sdkkvMIKHiKxeKOU5 tb0+LuFrLibbqioereNgo5KFtEFUVX9OtrCWlxzSXj9a/wzL20Gg2LrNnRN2H8jWfBvn Ri1aNYe7YoGhhy5fvysOnvlISTrk5x79TXVNDXDZZ6TLGPARHEgvec5L0f27S3SNuzhz IysA== X-Gm-Message-State: AOAM533Rb8zuo4NkxnA35vFHdYLnvYu4/9bHcIOIf9a6eu3OGg0zsNXr xRBAecVOCWKpWwkZ15ERqvc8yS23+J4n0AbiJaF2HQ== X-Google-Smtp-Source: ABdhPJyWPzmY+tyazkCwj4t0k4KGhEheNTDTa4+Z3XmMbe8kh4uk1AUlS/mwh8JLpJB4vJDlgZWe56Y+dIqi6GwmOz8= X-Received: by 2002:a05:6902:1025:: with SMTP id x5mr6466442ybt.96.1612984436001; Wed, 10 Feb 2021 11:13:56 -0800 (PST) MIME-Version: 1.0 References: <20210205222644.2357303-9-saravanak@google.com> <20210210114435.122242-1-tudor.ambarus@microchip.com> In-Reply-To: <20210210114435.122242-1-tudor.ambarus@microchip.com> From: Saravana Kannan Date: Wed, 10 Feb 2021 11:13:19 -0800 Message-ID: Subject: Re: [PATCH] clk: Mark fwnodes when their clock provider is added To: Tudor Ambarus Cc: Jonathan Corbet , Greg Kroah-Hartman , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , "Brown, Len" , Len Brown , Pavel Machek , Michael Turquette , Stephen Boyd , Rob Herring , Frank Rowand , Marc Zyngier , Thomas Gleixner , Nicolas Ferre , Claudiu Beznea , Linux Doc Mailing List , LKML , Linux PM , linux-clk , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ACPI Devel Maling List , Marek Szyprowski , Geert Uytterhoeven , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, Feb 10, 2021 at 3:44 AM Tudor Ambarus wrote: > > This is a follow-up for: > commit 3c9ea42802a1 ("clk: Mark fwnodes when their clock provider is added/removed") > > The above commit updated the deprecated of_clk_add_provider(), > but missed to update the preferred of_clk_add_hw_provider(). > Update it now. Thanks Tudor! Good catch! I checked to make sure the deregistration path undoes this one. So, it looks good to me. Reviewed-by: Saravana Kannan -Saravana > > Signed-off-by: Tudor Ambarus > --- > drivers/clk/clk.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 27ff90eacb1f..9370e4dfecae 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -4594,6 +4594,8 @@ int of_clk_add_hw_provider(struct device_node *np, > if (ret < 0) > of_clk_del_provider(np); > > + fwnode_dev_initialized(&np->fwnode, true); > + > return ret; > } > EXPORT_SYMBOL_GPL(of_clk_add_hw_provider); > -- > 2.25.1 >