From: Randy Dunlap <rdunlap@infradead.org>
To: Peter Enderborg <peter.enderborg@sony.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 2/2] debugfs: Add access restriction option
Date: Wed, 15 Jul 2020 20:30:24 -0700 [thread overview]
Message-ID: <b453a7d9-6620-2a28-205e-1a11bbcb5abd@infradead.org> (raw)
In-Reply-To: <20200715152529.11223-3-peter.enderborg@sony.com>
Hi,
On 7/15/20 8:25 AM, Peter Enderborg wrote:
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 9ad9210d70a1..aec81f38bfce 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -476,6 +476,38 @@ config DEBUG_FS
>
> If unsure, say N.
>
> +choice
> + prompt "Debugfs default access"
> + depends on DEBUG_FS
> + default DEBUG_FS_ALLOW_ALL
> + help
> + This select the default access restricions for debugfs.
selects restrictions
> + It can be overridden with kernel command line option
> + debugfs=[on,no-mount,off] The restrictions apply for API access
,off]. The
> + and filesystem registration. .
> +
> +config DEBUG_FS_ALLOW_ALL
> + bool "Access normal"
> + help
> + No restrictions applies. Both API and filesystem registration
apply.
> + is on. This is the normal default operation.
> +
> +config DEBUG_FS_DISALLOW_MOUNT
> + bool "Do not register debugfs as filesystem"
> + help
> + The API is open but filesystem not loaded. Client can still do
> + their work and readed with debug tools that does not need
and read that do not need
> + debugfs filesystem.
> +
> +config DEBUG_FS_ALLOW_NONE
> + bool "No access"
> + help
> + Access is off. Clients get EPERM when trying to create nodes in
-EPERM
> + debugfs tree and debugfs is not registred as an filesystem.
registered as a filesystem.
> + Client can then back-off or continue without debugfs access.
> +
> +endchoice
Also, in many places in this Kconfig file, the indentation needs to be
fixed. Some lines use spaces instead of one tab for indentation.
Help text (under "help") should be indented with one tab + 2 spaces.
--
~Randy
next prev parent reply other threads:[~2020-07-16 3:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 13:37 [PATCH v3] debugfs: Add access restriction option Peter Enderborg
2020-06-17 14:15 ` Greg Kroah-Hartman
2020-06-17 14:39 ` Enderborg, Peter
2020-06-17 15:10 ` Randy Dunlap
2020-06-22 8:30 ` [PATCH v4 0/2] " Peter Enderborg
2020-06-22 8:30 ` [PATCH 1/2] tracefs: Remove unnecessary debug_fs checks Peter Enderborg
2020-06-22 9:18 ` Greg Kroah-Hartman
2020-06-22 13:47 ` Steven Rostedt
2020-06-22 8:30 ` [PATCH 2/2] debugfs: Add access restriction option Peter Enderborg
2020-07-10 13:06 ` Greg Kroah-Hartman
2020-07-15 8:42 ` [PATCH v5 0/2] " Peter Enderborg
2020-07-15 8:42 ` [PATCH 1/2] tracefs: Remove unnecessary debug_fs checks Peter Enderborg
2020-07-15 8:42 ` [PATCH 2/2] debugfs: Add access restriction option Peter Enderborg
2020-07-15 9:39 ` Greg Kroah-Hartman
2020-07-15 10:03 ` Enderborg, Peter
2020-07-15 10:35 ` Greg Kroah-Hartman
2020-07-15 10:59 ` Enderborg, Peter
2020-07-21 6:47 ` Enderborg, Peter
2020-07-15 15:25 ` [PATCH v6 0/2] " Peter Enderborg
2020-07-15 15:25 ` [PATCH 1/2] tracefs: Remove unnecessary debug_fs checks Peter Enderborg
2020-07-15 15:25 ` [PATCH 2/2] debugfs: Add access restriction option Peter Enderborg
2020-07-16 3:30 ` Randy Dunlap [this message]
2020-07-16 4:54 ` [PATCH v7 0/2] " Peter Enderborg
2020-07-16 4:54 ` [PATCH 1/2] tracefs: Remove unnecessary debug_fs checks Peter Enderborg
2020-07-16 4:54 ` [PATCH 2/2] debugfs: Add access restriction option Peter Enderborg
2020-07-16 5:12 ` Randy Dunlap
2020-07-16 7:15 ` [PATCH v8 0/2] " Peter Enderborg
2020-07-16 7:15 ` [PATCH 1/2] tracefs: Remove unnecessary debug_fs checks Peter Enderborg
2020-07-16 7:15 ` [PATCH 2/2] debugfs: Add access restriction option Peter Enderborg
2020-07-16 15:26 ` Randy Dunlap
2020-07-23 15:11 ` [PATCH v8 0/2] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b453a7d9-6620-2a28-205e-1a11bbcb5abd@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peter.enderborg@sony.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).