From: Randy Dunlap <rdunlap@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: Jonathan Corbet <corbet@lwn.net>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Hugh Dickins <hughd@google.com>,
Matthew Wilcox <willy@infradead.org>, Zi Yan <ziy@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4] mm/vmstat: Add events for THP migration without split
Date: Thu, 9 Jul 2020 20:33:01 -0700 [thread overview]
Message-ID: <f360b009-e7b2-db5c-6d46-1daca76bea24@infradead.org> (raw)
In-Reply-To: <50cc0a0d-e04e-9e5d-26a6-73a91944ba8c@arm.com>
On 7/9/20 8:30 PM, Anshuman Khandual wrote:
>
> On 07/09/2020 09:04 PM, Randy Dunlap wrote:
>> Hi,
>>
>> I have a few comments on this.
>>
>> a. I reported it very early and should have been Cc-ed.
>
> I should have Cc-ed you on this V4 patch, sorry about that.
>
>>
>> b. A patch that applies to mmotm or linux-next would have been better
>> than a full replacement patch.
> I have followed that (i.e patch on mmotm/next as fix) only when the
> required change is smaller as compared to the series on mmotm/next.
> But for others a new patch should be better which can be replaced
> on mmotm and next. At least that is my understanding and would like
> to be corrected otherwise.
>
>>
>> c. I tried replacing what I believe is the correct/same patch file in mmotm
>> and still have build errors.
>
> That should not have happened, all new THP migration events are with
> CONFIG_MIGRATION rather than CONFIG_TRANSPARENT_HUGEPAGE previously.
Yes, I could have been mistaken about that last part. Sorry about that.
--
~Randy
prev parent reply other threads:[~2020-07-10 3:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 9:39 [PATCH V4] mm/vmstat: Add events for THP migration without split Anshuman Khandual
2020-07-09 15:34 ` Randy Dunlap
2020-07-09 16:34 ` Zi Yan
2020-07-09 16:39 ` Randy Dunlap
2020-07-09 17:42 ` Zi Yan
2020-07-09 20:15 ` John Hubbard
2020-07-09 21:24 ` Randy Dunlap
2020-07-10 3:41 ` Anshuman Khandual
2020-07-24 15:04 ` Daniel Jordan
2020-07-10 3:30 ` Anshuman Khandual
2020-07-10 3:33 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f360b009-e7b2-db5c-6d46-1daca76bea24@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=corbet@lwn.net \
--cc=daniel.m.jordan@oracle.com \
--cc=hughd@google.com \
--cc=jhubbard@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rostedt@goodmis.org \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).