From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Bjorn Helgaas <helgaas@kernel.org>, Guenter Roeck <linux@roeck-us.net>
Cc: "Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org, tim@buttersideup.com,
james.morse@arm.com, rrichter@marvell.com, jdelvare@suse.com,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
linux-crypto@vger.kernel.org, linux-edac@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 6/6] (v3) drivers: hwmon: i5k_amb: simplify probing / device identification
Date: Wed, 8 Jan 2020 11:16:47 +0100 [thread overview]
Message-ID: <07148b8e-5b87-66ad-e52b-be2b8b22e712@metux.net> (raw)
In-Reply-To: <20191210232529.GA171629@google.com>
On 11.12.19 00:25, Bjorn Helgaas wrote:
Hi,
> 2) I despise the pci_get_device() interfaces because they're
> inefficient, not hotplug-safe, they circumvent the device model
> claim mechanism, and it's hard to do the reference counting
> correctly.
Agreed, but for that we'd have to edac and hwmo driver together into
one (or maybe a MFD). That would be a major rewrite, and I don't have
the necessary HW to test it.
> 3) There are several things going on in this patch and it would be
> easier to read if you could split them into separate patches:
>
> - Removing the redundancy between chipset_ids[] and i5k_amb_ids[].
> This seems like a nice change.
>
> - The "chipset_ids[i].fbd0 + 1" thing was weird and the new
> ".driver_data + 1" is still weird. Those are PCI device IDs,
> and addition is not a valid operation on those IDs. IMHO both
> PCI_DEVICE_ID_INTEL_5000_FBD0 and PCI_DEVICE_ID_INTEL_5000_FBD1
> should be listed explicitly in the driver instead of trying to
> compute PCI_DEVICE_ID_INTEL_5000_FBD1.
Ok, good point.
> - Replacing the hard-coding of PCI_VENDOR_ID_INTEL with the vendor
> ID from i5k_amb_ids[] seems worthwhile and should be its own
> separate patch (if possible).
>
> - Changing to use pci_get_device_by_id(). This should be trivial
> to verify, like the other patches.
Ok, I'll try to split it up more clearly, once I've got some more spare
time.
--mtx
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
prev parent reply other threads:[~2020-01-08 10:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 12:54 [PATCH 1/6] include: linux: pci.h: introduce pci_get_device_by_id() Enrico Weigelt, metux IT consult
2019-11-28 12:54 ` [PATCH 2/6] mtd: maps: esb2rom: use pci_get_device_by_id() Enrico Weigelt, metux IT consult
2019-11-28 12:54 ` [PATCH 3/6] mtd: maps: amd76xrom: " Enrico Weigelt, metux IT consult
2019-11-28 12:54 ` [PATCH 4/6] edac: i82443bxgx_edac: " Enrico Weigelt, metux IT consult
2019-11-28 13:28 ` Robert Richter
2019-11-28 12:54 ` [PATCH 5/6] char: hw_random: intel-rng: " Enrico Weigelt, metux IT consult
2019-11-28 12:54 ` [PATCH 6/6] (v3) drivers: hwmon: i5k_amb: simplify probing / device identification Enrico Weigelt, metux IT consult
2019-11-28 14:21 ` Guenter Roeck
2019-12-10 23:25 ` Bjorn Helgaas
2020-01-08 10:16 ` Enrico Weigelt, metux IT consult [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07148b8e-5b87-66ad-e52b-be2b8b22e712@metux.net \
--to=lkml@metux.net \
--cc=helgaas@kernel.org \
--cc=info@metux.net \
--cc=james.morse@arm.com \
--cc=jdelvare@suse.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=rrichter@marvell.com \
--cc=tim@buttersideup.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).