From: "Naik, Avadhut" <avadnaik@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-trace-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
tony.luck@intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org, yazen.ghannam@amd.com,
Steven Rostedt <rostedt@goodmis.org>,
Avadhut Naik <avadhut.naik@amd.com>
Subject: Re: [PATCH v3 0/2] Update mce_record tracepoint
Date: Mon, 25 Mar 2024 16:39:45 -0500 [thread overview]
Message-ID: <16cfde5f-c198-4dc5-8e67-fa7f4af7e2cc@amd.com> (raw)
In-Reply-To: <20240325203147.GIZgHfM6yqPbK2YLOl@fat_crate.local>
On 3/25/2024 15:31, Borislav Petkov wrote:
> On Mon, Mar 25, 2024 at 03:12:14PM -0500, Naik, Avadhut wrote:
>> Can this patchset be merged in? Or would you prefer me sending out
>> another revision with Steven's "Reviewed-by:" tag?
>
> First of all, please do not top-post.
>
Apologies for that!
> Then, you were on Cc on the previous thread. Please summarize from it
> and put in the commit message *why* it is good to have each field added.
>
> And then, above the tracepoint, I'd like you to add a rule which
> states what information can and should be added to the tracepoint. And
> no, "just because" is not good enough. The previous thread has hints.
>
Thanks for the clarification! Will update accordingly.
> Thx.
>
--
Thanks,
Avadhut Naik
prev parent reply other threads:[~2024-03-25 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 7:57 [PATCH v3 0/2] Update mce_record tracepoint Avadhut Naik
2024-01-26 7:57 ` [PATCH v3 1/2] tracing: Include PPIN in " Avadhut Naik
2024-01-26 7:58 ` [PATCH v3 2/2] tracing: Include Microcode Revision " Avadhut Naik
2024-02-08 17:10 ` [PATCH v3 0/2] Update " Steven Rostedt
2024-03-25 20:12 ` Naik, Avadhut
2024-03-25 20:31 ` Borislav Petkov
2024-03-25 21:39 ` Naik, Avadhut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16cfde5f-c198-4dc5-8e67-fa7f4af7e2cc@amd.com \
--to=avadnaik@amd.com \
--cc=avadhut.naik@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).