From: "Hawa, Hanna" <hhhawa@amazon.com>
To: Rob Herring <robh@kernel.org>
Cc: <mark.rutland@arm.com>, <bp@alien8.de>, <mchehab@kernel.org>,
<james.morse@arm.com>, <davem@davemloft.net>,
<gregkh@linuxfoundation.org>, <linus.walleij@linaro.org>,
<Jonathan.Cameron@huawei.com>, <nicolas.ferre@microchip.com>,
<paulmck@linux.ibm.com>, <dwmw@amazon.co.uk>, <benh@amazon.com>,
<ronenk@amazon.com>, <talel@amazon.com>, <jonnyc@amazon.com>,
<hanochu@amazon.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v5 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC
Date: Mon, 26 Aug 2019 17:49:11 +0300 [thread overview]
Message-ID: <1d23d7c5-cd7b-1512-5300-d43e82ba6dc1@amazon.com> (raw)
In-Reply-To: <20190821191704.GA32425@bogus>
On 8/21/2019 10:17 PM, Rob Herring wrote:
> Why is this even in DT? AFAICT, this is all just CortexA57 core features
> (i.e. nothing Amazon specific). The core type and the ECC capabilities
> are discoverable.
Added to the DT in order to easily enable/disable the driver. You are
correct that they are CortexA57 core features and nothing Amazon
specific, but it's IMPLEMENTATION DEFINED, meaning that in different
cortex revisions (e.g. A57) the register bitmap may change. Because of
that we added an Amazon compatible which corresponds to the specific
core we are using.
Thanks,
Hanna
>
> Rob
next prev parent reply other threads:[~2019-08-26 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 14:39 [PATCH v5 0/4] Add support for Amazon's Annapurna Labs EDAC for L1/L2 Hanna Hawa
2019-08-05 14:39 ` [PATCH v5 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC Hanna Hawa
2019-08-21 19:17 ` Rob Herring
2019-08-26 14:49 ` Hawa, Hanna [this message]
2019-08-27 13:49 ` Rob Herring
2019-08-30 12:45 ` James Morse
2019-08-30 21:50 ` Rob Herring
2019-09-06 16:28 ` James Morse
2019-08-05 14:39 ` [PATCH v5 2/4] edac: Add support for " Hanna Hawa
2019-08-05 14:39 ` [PATCH v5 3/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L2 EDAC Hanna Hawa
2019-08-05 14:39 ` [PATCH v5 4/4] edac: Add support for " Hanna Hawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d23d7c5-cd7b-1512-5300-d43e82ba6dc1@amazon.com \
--to=hhhawa@amazon.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=benh@amazon.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=james.morse@arm.com \
--cc=jonnyc@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=paulmck@linux.ibm.com \
--cc=robh@kernel.org \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).