From: Borislav Petkov <bp@alien8.de>
To: Xie XiuQi <xiexiuqi@huawei.com>, James Morse <james.morse@arm.com>
Cc: tony.luck@intel.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] trace: ras: print the raw data of arm processor error info
Date: Thu, 9 Jan 2020 12:46:03 +0100 [thread overview]
Message-ID: <20200109114603.GC5603@zn.tnic> (raw)
In-Reply-To: <20191214121109.8349-1-xiexiuqi@huawei.com>
On Sat, Dec 14, 2019 at 08:11:09PM +0800, Xie XiuQi wrote:
> User space tools such as rasdaemon need the complete error
> information from trace event. So, we print the raw data of
> error information in arm_event.
>
> In the past, I try to parse them in trace event, but it's
> hard to deal the dynamic error item. And in commit 301f55b1a917
> ("efi: Parse ARM error information value"), the error information
> already been parsed to syslog.
>
> So, just print the raw data in trace event for simpler.
>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Tyler Baicar <tbaicar@codeaurora.org>
> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
> ---
> include/ras/ras_event.h | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h
> index 36c5c5e38c1d..2023ba9206b3 100644
> --- a/include/ras/ras_event.h
> +++ b/include/ras/ras_event.h
> @@ -180,6 +180,9 @@ TRACE_EVENT(arm_event,
> __field(u32, running_state)
> __field(u32, psci_state)
> __field(u8, affinity)
> + __field(u32, count)
> + __field(u32, len)
> + __dynamic_array(u8, err_info, proc->err_info_num * sizeof(struct cper_arm_err_info))
> ),
>
> TP_fast_assign(
> @@ -199,12 +202,18 @@ TRACE_EVENT(arm_event,
> __entry->running_state = ~0;
> __entry->psci_state = ~0;
> }
> +
> + __entry->count = proc->err_info_num;
> + __entry->len = __entry->count * sizeof(struct cper_arm_err_info);
> + memcpy(__get_dynamic_array(err_info), proc + 1, __entry->len);
> ),
>
> TP_printk("affinity level: %d; MPIDR: %016llx; MIDR: %016llx; "
> - "running state: %d; PSCI state: %d",
> + "running state: %d; PSCI state: %d; error count: %d; "
> + "raw data: %s",
> __entry->affinity, __entry->mpidr, __entry->midr,
> - __entry->running_state, __entry->psci_state)
> + __entry->running_state, __entry->psci_state, __entry->count,
> + __print_hex(__get_dynamic_array(err_info), __entry->len))
> );
>
> /*
> --
That's for ARM folks to decide whether they wanna shuffle raw error
records into userspace like that. CCed.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-01-09 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 12:11 [PATCH] trace: ras: print the raw data of arm processor error info Xie XiuQi
2019-12-16 10:17 ` Denverton decoding: BIOS performance setting Hermann Ruckerbauer
2020-01-09 11:46 ` Borislav Petkov [this message]
2020-01-13 14:10 ` [PATCH] trace: ras: print the raw data of arm processor error info Xie XiuQi
2020-02-26 15:14 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109114603.GC5603@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).