From: Borislav Petkov <bp@alien8.de>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
rrichter@marvell.com, michal.simek@xilinx.com,
manish.narani@xilinx.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
frank.li@nxp.com
Subject: Re: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter
Date: Sun, 15 Mar 2020 20:50:24 +0100 [thread overview]
Message-ID: <20200315195024.GB10926@zn.tnic> (raw)
In-Reply-To: <1582856183-5007-1-git-send-email-sherry.sun@nxp.com>
On Fri, Feb 28, 2020 at 10:16:23AM +0800, Sherry Sun wrote:
> Since ZynqMP platform call zynqmp_get_error_info() function to get ce/ue
> information. In this function, pinf->col parameter is not used, this
> parameter is only used by Zynq platforme in zynq_get_error_info(). So
> here pinf->col should not be called and printed for ZynqMP, need remove
> it.
Err, the interrupt handler intr_handler() calls the ->get_error_info()
function pointer and then calls handle_error(). I.e, the same path
ending in handle_error() is called on both: Zynq and ZynqMP, one through
the interrupt and the other through the poller.
Because it looks like the interrupt support is only on ZynqMP? I'm
looking at that DDR_ECC_INTR_SUPPORT thing.
If so, then you need to rename the interrupt handler to
zynqmp_intr_handler().
And normal Zynq platform uses check_errors() which then calls
handle_error().
So still not good enough: you probably "fixed" it on ZynqMP but broke
it on Zynq because check_errors() calls ->get_error_info() which is
zynq_get_error_info() and will have populated pinf->col.
You need to differentiate between Zynq and ZynqMP in handle_error() and
issue the proper string depending on the platform.
AFAICT.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-03-15 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 2:16 [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter Sherry Sun
2020-03-09 8:44 ` Manish Narani
2020-03-15 19:50 ` Borislav Petkov [this message]
2020-03-16 1:30 ` Sherry Sun
2020-03-16 10:43 ` Borislav Petkov
2020-03-16 12:28 ` Sherry Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315195024.GB10926@zn.tnic \
--to=bp@alien8.de \
--cc=frank.li@nxp.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rrichter@marvell.com \
--cc=sherry.sun@nxp.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).