Hi Robert,

I love your patch! Yet something to improve:

[auto build test ERROR on ras/edac-for-next]
[also build test ERROR on linus/master v5.7-rc2 next-20200423]
[cannot apply to bp/for-next linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Robert-Richter/EDAC-mc-ghes-Fixes-cleanup-and-reworks/20200424-042828
base:   https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from arch/x86/include/asm/bug.h:83:0,
                    from include/linux/bug.h:5,
                    from include/linux/debug_locks.h:7,
                    from include/linux/lockdep.h:44,
                    from include/linux/spinlock_types.h:18,
                    from include/linux/mutex.h:16,
                    from include/linux/kernfs.h:12,
                    from include/linux/sysfs.h:16,
                    from include/linux/kobject.h:20,
                    from include/linux/of.h:17,
                    from include/linux/irqdomain.h:35,
                    from include/linux/acpi.h:13,
                    from include/acpi/apei.h:9,
                    from include/acpi/ghes.h:5,
                    from drivers/edac/ghes_edac.c:12:
   drivers/edac/ghes_edac.c: In function 'ghes_dimm_pool_create':
>> include/linux/lockdep.h:409:52: error: invalid type argument of '->' (have 'struct mutex')
    #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
                                                       ^
   include/asm-generic/bug.h:113:25: note: in definition of macro 'WARN_ON'
     int __ret_warn_on = !!(condition);    \
                            ^~~~~~~~~
   include/linux/lockdep.h:435:27: note: in expansion of macro 'lockdep_is_held'
      WARN_ON(debug_locks && !lockdep_is_held(l)); \
                              ^~~~~~~~~~~~~~~
>> drivers/edac/ghes_edac.c:104:2: note: in expansion of macro 'lockdep_assert_held'
     lockdep_assert_held(ghes_reg_mutex);
     ^~~~~~~~~~~~~~~~~~~
   drivers/edac/ghes_edac.c: In function 'ghes_dimm_pool_destroy':
>> include/linux/lockdep.h:409:52: error: invalid type argument of '->' (have 'struct mutex')
    #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
                                                       ^
   include/asm-generic/bug.h:113:25: note: in definition of macro 'WARN_ON'
     int __ret_warn_on = !!(condition);    \
                            ^~~~~~~~~
   include/linux/lockdep.h:435:27: note: in expansion of macro 'lockdep_is_held'
      WARN_ON(debug_locks && !lockdep_is_held(l)); \
                              ^~~~~~~~~~~~~~~
   drivers/edac/ghes_edac.c:118:2: note: in expansion of macro 'lockdep_assert_held'
     lockdep_assert_held(ghes_reg_mutex);
     ^~~~~~~~~~~~~~~~~~~
   drivers/edac/ghes_edac.c: In function 'ghes_dimm_alloc':
>> include/linux/lockdep.h:409:52: error: invalid type argument of '->' (have 'struct mutex')
    #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
                                                       ^
   include/asm-generic/bug.h:113:25: note: in definition of macro 'WARN_ON'
     int __ret_warn_on = !!(condition);    \
                            ^~~~~~~~~
   include/linux/lockdep.h:435:27: note: in expansion of macro 'lockdep_is_held'
      WARN_ON(debug_locks && !lockdep_is_held(l)); \
                              ^~~~~~~~~~~~~~~
   drivers/edac/ghes_edac.c:127:2: note: in expansion of macro 'lockdep_assert_held'
     lockdep_assert_held(ghes_reg_mutex);
     ^~~~~~~~~~~~~~~~~~~
   drivers/edac/ghes_edac.c: In function 'ghes_dimm_release':
>> include/linux/lockdep.h:409:52: error: invalid type argument of '->' (have 'struct mutex')
    #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
                                                       ^
   include/asm-generic/bug.h:113:25: note: in definition of macro 'WARN_ON'
     int __ret_warn_on = !!(condition);    \
                            ^~~~~~~~~
   include/linux/lockdep.h:435:27: note: in expansion of macro 'lockdep_is_held'
      WARN_ON(debug_locks && !lockdep_is_held(l)); \
                              ^~~~~~~~~~~~~~~
   drivers/edac/ghes_edac.c:144:2: note: in expansion of macro 'lockdep_assert_held'
     lockdep_assert_held(ghes_reg_mutex);
     ^~~~~~~~~~~~~~~~~~~

vim +/lockdep_assert_held +104 drivers/edac/ghes_edac.c

    96	
    97	static int ghes_dimm_pool_create(int num_dimm)
    98	{
    99		struct ghes_dimm *ghes_dimm;
   100	
   101		if (!num_dimm)
   102			return 0;
   103	
 > 104		lockdep_assert_held(ghes_reg_mutex);
   105	
   106		dimms = kcalloc(num_dimm, sizeof(*dimms), GFP_KERNEL);
   107		if (!dimms)
   108			return -ENOMEM;
   109	
   110		for (ghes_dimm = dimms; ghes_dimm < dimms + num_dimm; ghes_dimm++)
   111			list_add(&ghes_dimm->entry, &ghes_dimm_pool);
   112	
   113		return 0;
   114	}
   115	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org