From: Greg KH <gregkh@linuxfoundation.org>
To: "Manali Shukla (manashuk)" <manashuk@cisco.com>
Cc: Borislav Petkov <bp@suse.de>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
Aristeu Rozanski Filho <arozansk@redhat.com>,
Justin Ernst <justin.ernst@hpe.com>, Russ Anderson <rja@hpe.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [ PATCH stable v4.19] EDAC: Drop per-memory controller buses
Date: Tue, 16 Jun 2020 12:37:06 +0200 [thread overview]
Message-ID: <20200616103706.GA2653240@kroah.com> (raw)
In-Reply-To: <994FAF5C-B773-4B09-8C08-91E22ECDB8A9@cisco.com>
On Sun, Apr 05, 2020 at 07:26:01PM +0000, Manali Shukla (manashuk) wrote:
> > On 05/04/20, 11:36 PM, "Borislav Petkov" <bp@suse.de> wrote:
>
> > On Sun, Apr 05, 2020 at 06:01:21PM +0000, Manali Shukla (manashuk) wrote:
> >> With this patch , we are removing per-MC bus, this removes dependency on value of max number of controllers (EDAC_MAX_MCS) which is hardcoded to 2 * MAX_NUMNODES in all stable versions of kernel.
> >> On two nodes system MAX_NUMNODES value is ‘1’ , so value of max number of memory controller becomes ‘2’, this patch fixes this issue when there are only 2 nodes on the system and number of memory controllers are more than ‘2'
>
> > You basically repeated what you had written already.
>
> > But what is this fixing? Some platform of yours or what? Why does it
> > need to go to stable?
>
> Certain MIPS platform can have 2 nodes and number of memory controllers can be more than '2' .
>
> for above condition, if
> #define EDAC_MAX_MCS 2 * MAX_NUMNODES,
> it fails in this function edac_mc_add_mc_with_groups
> in below condition
> if (mci->mc_idx >= EDAC_MAX_MCS) {
> pr_warn_once("Too many memory controllers: %d\n", mci->mc_idx);
> return -ENODEV;
> }
> That is why this fix is needed.
What fix?
I see no patch in this email, nor do I see a git commit id anywhere :(
Totally confused,
greg k-h
prev parent reply other threads:[~2020-06-16 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 5:22 [ PATCH stable v4.19] EDAC: Drop per-memory controller buses Manali K Shukla
2020-03-17 10:22 ` Greg KH
2020-04-05 18:01 ` Manali Shukla (manashuk)
2020-04-05 18:06 ` Borislav Petkov
2020-04-05 19:26 ` Manali Shukla (manashuk)
2020-06-16 10:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616103706.GA2653240@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arozansk@redhat.com \
--cc=bp@suse.de \
--cc=justin.ernst@hpe.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manashuk@cisco.com \
--cc=mchehab@kernel.org \
--cc=rja@hpe.com \
--cc=tony.luck@intel.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).