From: peterz@infradead.org
To: hpa@zytor.com
Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>,
Andy Lutomirski <luto@kernel.org>,
x86@kernel.org, Dave Hansen <dave.hansen@intel.com>,
Tony Luck <tony.luck@intel.com>,
Cathy Zhang <cathy.zhang@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Kyung Min Park <kyung.min.park@intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
linux-kernel@vger.kernel.org,
Ricardo Neri <ricardo.neri@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH 4/4] x86/cpu: Use SERIALIZE in sync_core() when available
Date: Mon, 27 Jul 2020 15:05:36 +0200 [thread overview]
Message-ID: <20200727130536.GM119549@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <49251CFA-8AC3-462D-A60F-0337593BE9CD@zytor.com>
On Mon, Jul 27, 2020 at 05:49:28AM -0700, hpa@zytor.com wrote:
> On July 27, 2020 1:36:19 AM PDT, peterz@infradead.org wrote:
> >On Sun, Jul 26, 2020 at 10:55:15PM -0700, hpa@zytor.com wrote:
> >> For a really overenginered solution, but which might perform
> >> unnecessary poorly on existing hardware:
> >>
> >> asm volatile("1: .byte 0xf, 0x1, 0xe8; 2:"
> >> _ASM_EXTABLE(1b,2b));
> >
> >Ha! cute, you take an #UD ?
> >
> >We could optimize the #UD exception handler for this I suppose, but
> >that makes it an even worse hack. The simple alternative() seems like
> >a much simpler approach.
>
> If this is in any way performance critical, then no :)
Yeah, I'm not sure.. the 'funny' thing is that typically call
sync_core() from an IPI anyway. And the synchronous broadcast IPI is by
far the most expensive part of that.
Something like this...
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 20e07feb4064..528e049ee1d9 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -989,12 +989,13 @@ void *text_poke_kgdb(void *addr, const void *opcode, size_t len)
static void do_sync_core(void *info)
{
- sync_core();
+ /* IRET implies sync_core() */
}
void text_poke_sync(void)
{
on_each_cpu(do_sync_core, NULL, 1);
+ sync_core();
}
struct text_poke_loc {
> Taking the #UD
> has the cute property that we end up IRET on the way back, so we don't
> even need a fix-up path.
I got that, what I had in mind was making sure #UD avoids the overhead
of doing exception entry/exit by adding an early exit.
Something like so:
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 8493f55e1167..a3f41d645944 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -96,6 +96,16 @@ __always_inline int is_valid_bugaddr(unsigned long addr)
return *(unsigned short *)addr == INSN_UD2;
}
+__always_inline int handle_serialize(struct pt_regs *regs)
+{
+ const char serialize[3] = { 0x0f, 0xe8, 0x02 };
+
+ if (regs->ip < TASK_SIZE_MAX)
+ return 0;
+
+ return !memcmp((const void *)regs->ip, serialize, 3);
+}
+
static nokprobe_inline int
do_trap_no_signal(struct task_struct *tsk, int trapnr, const char *str,
struct pt_regs *regs, long error_code)
@@ -252,8 +262,13 @@ DEFINE_IDTENTRY_RAW(exc_invalid_op)
* handle it before exception entry to avoid recursive WARN
* in case exception entry is the one triggering WARNs.
*/
- if (!user_mode(regs) && handle_bug(regs))
- return;
+ if (!user_mode(regs)) {
+ if (handle_bug(regs))
+ return;
+
+ if (handle_serialize(regs))
+ return;
+ }
state = idtentry_enter(regs);
instrumentation_begin();
next prev parent reply other threads:[~2020-07-27 13:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200727043132.15082-1-ricardo.neri-calderon@linux.intel.com>
2020-07-27 4:31 ` [PATCH 1/4] x86/cpufeatures: Add enumeration for SERIALIZE instruction Ricardo Neri
2020-07-27 4:31 ` [PATCH 2/4] x86/cpu: Relocate sync_core() to sync_core.h Ricardo Neri
2020-07-27 4:31 ` [PATCH 3/4] x86/cpu: Refactor sync_core() for readability Ricardo Neri
2020-07-27 4:31 ` [PATCH 4/4] x86/cpu: Use SERIALIZE in sync_core() when available Ricardo Neri
2020-07-27 5:55 ` hpa
2020-07-27 6:00 ` hpa
2020-07-27 8:36 ` peterz
2020-07-27 12:49 ` hpa
2020-07-27 13:05 ` peterz [this message]
2020-07-27 13:30 ` peterz
2020-07-28 4:41 ` Ricardo Neri
2020-07-28 8:50 ` peterz
2020-07-27 16:27 ` Luck, Tony
2020-07-27 8:20 ` peterz
2020-07-27 12:47 ` hpa
2020-07-28 0:55 ` Ricardo Neri
2020-07-28 0:36 ` Ricardo Neri
2020-07-27 8:23 ` peterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727130536.GM119549@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@suse.de \
--cc=cathy.zhang@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=kyung.min.park@intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).