From: Borislav Petkov <bp@alien8.de>
To: Luca Stefani <luca.stefani.ge1@gmail.com>
Cc: Tony Luck <tony.luck@intel.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RAS/CEC: Fix cec_init prototype
Date: Wed, 5 Aug 2020 06:59:55 +0200 [thread overview]
Message-ID: <20200805045955.GB9127@nazgul.tnic> (raw)
In-Reply-To: <20200804161847.825391-1-luca.stefani.ge1@gmail.com>
On Tue, Aug 04, 2020 at 06:18:47PM +0200, Luca Stefani wrote:
> * late_initcall expects a function to return an integer
Please write a proper sentence for a commit message.
> Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>
> ---
> drivers/ras/cec.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
> index 569d9ad2c594..e048e0e3949a 100644
> --- a/drivers/ras/cec.c
> +++ b/drivers/ras/cec.c
> @@ -553,20 +553,20 @@ static struct notifier_block cec_nb = {
> .priority = MCE_PRIO_CEC,
> };
>
> -static void __init cec_init(void)
> +static int __init cec_init(void)
> {
> if (ce_arr.disabled)
> - return;
> + return 0;
Why 0?
I'm thinking all the cases when the init doesn't succeed should return
!0...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-08-05 5:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 16:18 [PATCH] RAS/CEC: Fix cec_init prototype Luca Stefani
2020-08-05 4:59 ` Borislav Petkov [this message]
2020-08-05 9:57 ` [PATCH v2] " Luca Stefani
2020-08-12 21:09 ` Sami Tolvanen
2020-08-17 15:13 ` Borislav Petkov
2020-08-17 15:58 ` Sami Tolvanen
2020-08-17 17:41 ` Borislav Petkov
2020-08-17 18:11 ` Sami Tolvanen
2020-08-17 18:54 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805045955.GB9127@nazgul.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.stefani.ge1@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).