From: Borislav Petkov <bp@alien8.de>
To: Troy Lee <troy_lee@aspeedtech.com>
Cc: Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Tony Luck <tony.luck@intel.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
James Morse <james.morse@arm.com>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
open list <linux-kernel@vger.kernel.org>,
Robert Richter <rrichter@marvell.com>,
"leetroy@gmail.com" <leetroy@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Stefan M Schaeckeler <sschaeck@cisco.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver
Date: Thu, 3 Dec 2020 08:20:36 +0100 [thread overview]
Message-ID: <20201203072036.GB3059@zn.tnic> (raw)
In-Reply-To: <PS1PR06MB2600D6A1E73D89EA0D0D59DC8AF20@PS1PR06MB2600.apcprd06.prod.outlook.com>
On Thu, Dec 03, 2020 at 01:27:27AM +0000, Troy Lee wrote:
> Hi Broislav and Andrew,
>
> I removed these exported function and submitted v3 PATCH.
I saw that. A couple of comments:
First of all, please do not top-post on a public mailing list.
Secondly, Joel gave you Reviewed-by: and Acked-by: for your patches 1
and 2 which are not in your new submission. But they should be, please
have a look at Documentation/process/ while you're waiting for his
review of your v3.
You don't have to resend now with those added and I can add them if Joel
is fine with patch 3 but pls remember to pick up tags reviewers have
given you, in the future.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-12-03 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 6:36 [PATCH v2 1/3] dt-bindings: edac: aspeed-sdram-edac: Add ast2400/ast2600 support Troy Lee
2020-12-02 6:36 ` [PATCH v2 2/3] ARM: dts: aspeed: Add AST2600 edac into common devicetree Troy Lee
2020-12-02 7:02 ` Joel Stanley
2020-12-02 6:36 ` [PATCH v2 3/3] edac: Supporting AST2400 and AST2600 edac driver Troy Lee
2020-12-02 7:01 ` Joel Stanley
2020-12-02 8:41 ` Troy Lee
2020-12-02 15:02 ` Andrew Jeffery
2020-12-02 18:23 ` Borislav Petkov
2020-12-03 1:27 ` Troy Lee
2020-12-03 7:20 ` Borislav Petkov [this message]
2020-12-02 6:40 ` [PATCH v2 1/3] dt-bindings: edac: aspeed-sdram-edac: Add ast2400/ast2600 support Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203072036.GB3059@zn.tnic \
--to=bp@alien8.de \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=james.morse@arm.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rrichter@marvell.com \
--cc=ryan_chen@aspeedtech.com \
--cc=sschaeck@cisco.com \
--cc=tony.luck@intel.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).