From: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
James Morse <james.morse@arm.com>,
yazen.ghannam@amd.com, Robert Richter <rric@kernel.org>,
Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Subject: [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed
Date: Mon, 14 Jun 2021 16:21:29 -0500 [thread overview]
Message-ID: <20210614212129.227698-1-Smita.KoralahalliChannabasappa@amd.com> (raw)
The SMCA feature bit is not exposed on the guest.
This causes a lot of noise in dmesg as the warning is printed for each
logical CPU.
$ dmesg |grep -i family
[ 0.031000] smpboot: CPU0: AMD EPYC-Milan Processor (family: 0x19, model: 0x1, stepping: 0x1)
[ 4.653422] Huh? What family is it: 0x19?!
[ 4.720732] Huh? What family is it: 0x19?!
[ 6.171028] Huh? What family is it: 0x19?!
[ 6.766552] Huh? What family is it: 0x19?!
[ 6.811119] Huh? What family is it: 0x19?!
[ 6.839855] Huh? What family is it: 0x19?!
Give these messages debug severity and output once as it is mostly useful
for module developers and just noise for users.
Rephrase the statement to make it more meaningful.
Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
---
drivers/edac/mce_amd.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index 5dd905a3f30c..2a9899088389 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -1227,13 +1227,9 @@ static int __init mce_amd_init(void)
fam_ops.mc2_mce = f16h_mc2_mce;
break;
- case 0x17:
- case 0x18:
- pr_warn_once("Decoding supported only on Scalable MCA processors.\n");
- return -EINVAL;
-
default:
- printk(KERN_WARNING "Huh? What family is it: 0x%x?!\n", c->x86);
+ pr_debug_once("MCE decoding is not supported for family: 0x%x\n",
+ c->x86);
return -EINVAL;
}
--
2.17.1
next reply other threads:[~2021-06-14 21:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 21:21 Smita Koralahalli [this message]
2021-06-14 22:01 ` [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed Borislav Petkov
2021-06-14 22:25 ` Luck, Tony
2021-06-15 9:16 ` Borislav Petkov
2021-06-15 15:08 ` Yazen Ghannam
2021-06-15 15:18 ` Borislav Petkov
2021-06-15 16:00 ` Yazen Ghannam
2021-06-15 16:11 ` Borislav Petkov
2021-06-15 16:32 ` Yazen Ghannam
2021-06-15 16:45 ` [PATCH] EDAC/Intel: Do not load EDAC driver when running as a guest Luck, Tony
2021-06-15 17:00 ` Borislav Petkov
2021-06-15 17:44 ` [PATCH v2] " Luck, Tony
2021-06-15 17:25 ` [PATCH] EDAC/mce_amd: Reduce unnecessary spew in dmesg if SMCA feature bit is not exposed Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614212129.227698-1-Smita.KoralahalliChannabasappa@amd.com \
--to=smita.koralahallichannabasappa@amd.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).