From: Bixuan Cui <cuibixuan@huawei.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Tero Kristo <kristo@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>, <linux-edac@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] EDAC: ti: Add missing MODULE_DEVICE_TABLE
Date: Tue, 11 May 2021 21:51:33 +0800 [thread overview]
Message-ID: <3dbb6474-7e9a-3b84-9fc4-58bf80614e44@huawei.com> (raw)
In-Reply-To: <YJprIzhI9UF5wVQp@zn.tnic>
On 2021/5/11 19:31, Borislav Petkov wrote:
> On Sat, May 08, 2021 at 11:15:06AM +0800, Bixuan Cui wrote:
>> This patch adds missing MODULE_DEVICE_TABLE definition which generates
>
> Avoid having "This patch" or "This commit" in the commit message. It is
> tautologically useless.
>
> Also, do
>
> $ git grep 'This patch' Documentation/process
>
> for more details.
>
>> correct modalias for automatic loading of this driver when it is built
>> as an external module.
>
> "external" or simply a module?
I will modify the commit message, thanks.
Bixuan Cui
>
prev parent reply other threads:[~2021-05-11 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 3:15 [PATCH -next] EDAC: ti: Add missing MODULE_DEVICE_TABLE Bixuan Cui
2021-05-11 11:31 ` Borislav Petkov
2021-05-11 13:51 ` Bixuan Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbb6474-7e9a-3b84-9fc4-58bf80614e44@huawei.com \
--to=cuibixuan@huawei.com \
--cc=bp@alien8.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).