From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Evan Green <evgreen@chromium.org>,
Mark Rutland <mark.rutland@arm.com>,
OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>, Tony Luck <tony.luck@intel.com>,
psodagud@codeaurora.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
tsoni@codeaurora.org, LKML <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Robert Richter <rrichter@marvell.com>,
Andy Gross <agross@kernel.org>, Borislav Petkov <bp@alien8.de>,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
linux-edac@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers: edac: Add EDAC support for Kryo CPU caches
Date: Fri, 13 Dec 2019 11:01:23 +0530 [thread overview]
Message-ID: <624229b9b2d5bf4b5eccf7778b420e2d@codeaurora.org> (raw)
In-Reply-To: <5df16ebe.1c69fb81.6481f.a011@mx.google.com>
On 2019-12-12 04:03, Stephen Boyd wrote:
> Quoting Evan Green (2019-12-11 11:32:37)
>> Hi Sai,
>>
>> On Thu, Dec 5, 2019 at 1:53 AM Sai Prakash Ranjan
>> <saiprakash.ranjan@codeaurora.org> wrote:
>> > diff --git a/drivers/edac/qcom_kryo_edac.c b/drivers/edac/qcom_kryo_edac.c
>> > new file mode 100644
>> > index 000000000000..05b60ad3cb0e
>> > --- /dev/null
>> > +++ b/drivers/edac/qcom_kryo_edac.c
>> > @@ -0,0 +1,679 @@
> [...]
>> > +static const struct error_record serror_record[] = {
>> > + { 0x1, "Errors due to fault injection" },
>> > + { 0x2, "ECC error from internal data buffer" },
>> > + { 0x6, "ECC error on cache data RAM" },
>> > + { 0x7, "ECC error on cache tag or dirty RAM" },
>> > + { 0x8, "Parity error on TLB data RAM" },
>> > + { 0x9, "Parity error on TLB tag RAM" },
>> > + { 0x12, "Error response for a cache copyback" },
>> > + { 0x15, "Deferred error not supported" },
>> > +};
>> > +
>> > +static const struct error_type err_type[] = {
>> > + { edac_device_handle_ce, "Kryo L1 Corrected Error" },
>> > + { edac_device_handle_ue, "Kryo L1 Uncorrected Error" },
>> > + { edac_device_handle_ue, "Kryo L1 Deferred Error" },
>> > + { edac_device_handle_ce, "Kryo L2 Corrected Error" },
>> > + { edac_device_handle_ue, "Kryo L2 Uncorrected Error" },
>> > + { edac_device_handle_ue, "Kryo L2 Deferred Error" },
>> > + { edac_device_handle_ce, "L3 Corrected Error" },
>> > + { edac_device_handle_ue, "L3 Uncorrected Error" },
>> > + { edac_device_handle_ue, "L3 Deferred Error" },
>> > +};
>>
>> A comment is warranted to indicate that err_type is indexed by the
>> enum, as this would be easy to mess up in later changes.
>
> Instead of a comment please use array indexing.
>
> [KRYO_L1_CE] = { edac_device_handle_ce, "Kryo L1..." },
> ...
Will do this in the next spin.
-Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-12-13 5:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1575529553.git.saiprakash.ranjan@codeaurora.org>
2019-12-05 9:53 ` [PATCH 1/2] dt-bindings: edac: Add DT bindings for Kryo EDAC Sai Prakash Ranjan
2019-12-18 23:37 ` Rob Herring
2019-12-19 6:50 ` Sai Prakash Ranjan
2019-12-19 13:58 ` Rob Herring
2019-12-19 14:48 ` Sai Prakash Ranjan
2020-01-15 18:48 ` James Morse
2020-01-24 14:21 ` Sai Prakash Ranjan
2020-02-26 17:12 ` James Morse
2019-12-05 9:53 ` [PATCH 2/2] drivers: edac: Add EDAC support for Kryo CPU caches Sai Prakash Ranjan
[not found] ` <0101016ed57a6311-e815485c-4b77-4342-a3de-203673941602-000000@us-west-2.amazonses.com>
2019-12-11 19:32 ` Evan Green
[not found] ` <5df16ebe.1c69fb81.6481f.a011@mx.google.com>
2019-12-13 5:31 ` Sai Prakash Ranjan [this message]
[not found] ` <0101016ed57a6559-46c6c649-db28-4945-a11c-7441b8e9ac5b-000000@us-west-2.amazonses.com>
2019-12-30 11:50 ` Borislav Petkov
2020-01-13 5:44 ` Sai Prakash Ranjan
2020-01-15 18:49 ` James Morse
2020-01-24 14:52 ` Sai Prakash Ranjan
2019-12-13 9:05 Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624229b9b2d5bf4b5eccf7778b420e2d@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=psodagud@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rrichter@marvell.com \
--cc=swboyd@chromium.org \
--cc=tony.luck@intel.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).