From: Miaohe Lin <linmiaohe@huawei.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: <tony.luck@intel.com>, <bp@alien8.de>, <tglx@linutronix.de>,
<mingo@redhat.com>, <dave.hansen@linux.intel.com>,
<hpa@zytor.com>, <x86@kernel.org>, <linux-edac@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/mce: remove unused mce_vaddr
Date: Sat, 3 Jun 2023 11:17:08 +0800 [thread overview]
Message-ID: <6f36b268-0717-1bb4-6f78-53758a88c04a@huawei.com> (raw)
In-Reply-To: <ZHZLjRPSYCOYjkBo@aschofie-mobl2>
On 2023/5/31 3:16, Alison Schofield wrote:
> On Sun, May 28, 2023 at 07:35:45PM +0800, Miaohe Lin wrote:
>> Since commit a6e3cf70b772 ("x86/mce: Change to not send SIGBUS error during
>> copy from user"), mce_vaddr is not used anymore. Remove it and clean up the
>> relevant code.
>
> Hi Miaohe,
>
> Not so sure that the 'clean up' part is useful. See below.
>
>
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>> arch/x86/kernel/cpu/mce/severity.c | 7 +------
>> include/linux/sched.h | 1 -
>> 2 files changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/mce/severity.c b/arch/x86/kernel/cpu/mce/severity.c
>> index c4477162c07d..0acc0039de81 100644
>> --- a/arch/x86/kernel/cpu/mce/severity.c
>> +++ b/arch/x86/kernel/cpu/mce/severity.c
>> @@ -252,12 +252,7 @@ static bool is_copy_from_user(struct pt_regs *regs)
>> return false;
>> }
>>
>> - if (fault_in_kernel_space(addr))
>> - return false;
>> -
>> - current->mce_vaddr = (void __user *)addr;
>> -
>> - return true;
>> + return !fault_in_kernel_space(addr);
>> }
>
>
> Refactoring the return is unnecessary and seems less readable.
> How about removing the assignment, and leaving the rest, as is:
>
> diff --git a/arch/x86/kernel/cpu/mce/severity.c b/arch/x86/kernel/cpu/mce/severity.c
> index c4477162c07d..1c03221ddcb1 100644
> --- a/arch/x86/kernel/cpu/mce/severity.c
> +++ b/arch/x86/kernel/cpu/mce/severity.c
> @@ -255,8 +255,6 @@ static bool is_copy_from_user(struct pt_regs *regs)
> if (fault_in_kernel_space(addr))
> return false;
>
> - current->mce_vaddr = (void __user *)addr;
> -
> return true;
> }
>
Sounds good to me. Will do it in v2. Thanks for your advice.
prev parent reply other threads:[~2023-06-03 3:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 11:35 [PATCH] x86/mce: remove unused mce_vaddr Miaohe Lin
2023-05-30 19:16 ` Alison Schofield
2023-06-03 3:17 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f36b268-0717-1bb4-6f78-53758a88c04a@huawei.com \
--to=linmiaohe@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).