From: "Datta, Shubhrajyoti" <shubhrajyoti.datta@amd.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>,
"Borislav Petkov" <bp@alien8.de>,
"Tony Luck" <tony.luck@intel.com>
Cc: James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [PATCH] EDAC/versal: Convert to platform remove callback returning void
Date: Fri, 8 Mar 2024 08:55:07 +0000 [thread overview]
Message-ID: <BY5PR12MB4902011971E052DFFC42D2D881272@BY5PR12MB4902.namprd12.prod.outlook.com> (raw)
In-Reply-To: <83deca1ce260f7e17ff3cb106c9a6946d4ca4505.1709886922.git.u.kleine-koenig@pengutronix.de>
[AMD Official Use Only - General]
> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Sent: Friday, March 8, 2024 2:21 PM
> To: Datta, Shubhrajyoti <shubhrajyoti.datta@amd.com>; Potthuri, Sai
> Krishna <sai.krishna.potthuri@amd.com>; Borislav Petkov <bp@alien8.de>;
> Tony Luck <tony.luck@intel.com>
> Cc: James Morse <james.morse@arm.com>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; Robert Richter <rric@kernel.org>; linux-
> edac@vger.kernel.org; kernel@pengutronix.de
> Subject: [PATCH] EDAC/versal: Convert to platform remove callback
> returning void
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return void. In
> the first step of this quest all drivers are converted to .remove_new(), which
> already returns void. Eventually after all drivers are converted,
> .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Reviewed-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
next prev parent reply other threads:[~2024-03-08 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:51 [PATCH] EDAC/versal: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-08 8:55 ` Datta, Shubhrajyoti [this message]
2024-03-08 13:00 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB4902011971E052DFFC42D2D881272@BY5PR12MB4902.namprd12.prod.outlook.com \
--to=shubhrajyoti.datta@amd.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=kernel@pengutronix.de \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=sai.krishna.potthuri@amd.com \
--cc=tony.luck@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).