From: "Luck, Tony" <tony.luck@intel.com>
To: "Naik, Avadhut" <avadnaik@amd.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Cc: "bp@alien8.de" <bp@alien8.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
Avadhut Naik <avadhut.naik@amd.com>
Subject: RE: [PATCH 1/2] x86/MCE: Extend size of the MCE Records pool
Date: Thu, 8 Feb 2024 18:39:05 +0000 [thread overview]
Message-ID: <SJ1PR11MB6083F74E1C45F06860A29A38FC442@SJ1PR11MB6083.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3281ec05-60cb-4fa2-8562-afa93e770159@amd.com>
> Will change it to (2 * sizeof(struct mce)) though. Feels more
> accurate. Thanks for the suggestion!
Thanks.
> Do you have any additional concerns/comments on this patchset?
Overall this is an excellent addition. Reserved space to log errors does need to scale
up with the CPU count.
I think part 1 (unconditional increase based on CPU count) is a "must have" enhancement.
With the change to CPU_GEN_MEMSZ #define:
Reviewed-by: Tony Luck <tony.luck@intel.com>
I'm less enthusiastic about part 2 adding a command line option to override the code in
part 1 with a bigger (or smaller?) amount. Can you describe some situation where a user
would need to use this?
-Tony
next prev parent reply other threads:[~2024-02-08 18:39 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 22:56 [PATCH 0/2] Extend size of the MCE Records pool Avadhut Naik
2024-02-07 22:56 ` [PATCH 1/2] x86/MCE: " Avadhut Naik
2024-02-08 0:02 ` Luck, Tony
2024-02-08 17:41 ` Naik, Avadhut
2024-02-08 17:47 ` Naik, Avadhut
2024-02-08 18:39 ` Luck, Tony [this message]
2024-02-09 19:47 ` Naik, Avadhut
2024-02-08 21:09 ` Sohil Mehta
2024-02-09 19:52 ` Naik, Avadhut
2024-02-07 22:56 ` [PATCH 2/2] x86/MCE: Add command line option to extend " Avadhut Naik
2024-02-09 1:36 ` Sohil Mehta
2024-02-09 20:02 ` Naik, Avadhut
2024-02-09 20:09 ` Borislav Petkov
2024-02-09 20:35 ` Naik, Avadhut
2024-02-09 20:51 ` Borislav Petkov
2024-02-10 7:52 ` Borislav Petkov
2024-02-10 21:15 ` Naik, Avadhut
2024-02-11 11:14 ` Borislav Petkov
2024-02-12 2:54 ` Naik, Avadhut
2024-02-12 8:58 ` Borislav Petkov
2024-02-12 9:32 ` Borislav Petkov
2024-02-12 17:29 ` Luck, Tony
2024-02-12 17:54 ` Borislav Petkov
2024-02-12 18:45 ` Luck, Tony
2024-02-12 19:14 ` Borislav Petkov
2024-02-12 19:41 ` Luck, Tony
2024-02-12 21:37 ` Tony Luck
2024-02-12 22:08 ` Borislav Petkov
2024-02-12 22:19 ` Borislav Petkov
2024-02-12 22:42 ` Borislav Petkov
2024-02-28 23:14 ` [PATCH] x86/mce: Dynamically size space for machine check records Tony Luck
2024-02-29 0:39 ` Sohil Mehta
2024-02-29 0:44 ` Luck, Tony
2024-02-29 1:56 ` Sohil Mehta
2024-02-29 15:49 ` Yazen Ghannam
2024-02-29 17:22 ` Tony Luck
2024-02-29 17:21 ` Tony Luck
2024-02-29 23:56 ` Sohil Mehta
2024-02-29 6:42 ` Naik, Avadhut
2024-02-29 8:39 ` Borislav Petkov
2024-02-29 17:47 ` Tony Luck
2024-02-29 18:28 ` Naik, Avadhut
2024-02-29 18:38 ` Luck, Tony
2024-02-29 17:26 ` Tony Luck
2024-03-06 21:52 ` Naik, Avadhut
2024-03-06 22:07 ` Luck, Tony
2024-03-06 23:21 ` Naik, Avadhut
2024-02-15 20:18 ` [PATCH 2/2] x86/MCE: Add command line option to extend MCE Records pool Naik, Avadhut
2024-02-15 20:15 ` Naik, Avadhut
2024-02-15 20:14 ` Naik, Avadhut
2024-02-12 18:47 ` Yazen Ghannam
2024-02-12 18:58 ` Luck, Tony
2024-02-12 19:40 ` Naik, Avadhut
2024-02-12 20:18 ` Borislav Petkov
2024-02-12 20:51 ` Naik, Avadhut
2024-02-12 19:43 ` Yazen Ghannam
2024-02-12 19:49 ` Luck, Tony
2024-02-12 20:10 ` Borislav Petkov
2024-02-12 20:44 ` Paul E. McKenney
2024-02-12 21:18 ` Luck, Tony
2024-02-12 21:27 ` Borislav Petkov
2024-02-12 22:46 ` Paul E. McKenney
2024-02-12 22:53 ` Luck, Tony
2024-02-12 23:10 ` Borislav Petkov
2024-02-13 1:07 ` Paul E. McKenney
2024-02-09 20:16 ` Sohil Mehta
2024-02-09 20:28 ` Luck, Tony
2024-02-09 21:02 ` Sohil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ1PR11MB6083F74E1C45F06860A29A38FC442@SJ1PR11MB6083.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=avadhut.naik@amd.com \
--cc=avadnaik@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).