From: <Narendra.K@dell.com>
To: <Mario.Limonciello@dell.com>
Cc: <ard.biesheuvel@linaro.org>, <geert@linux-m68k.org>,
<Narendra.K@dell.com>, <linux-efi@vger.kernel.org>,
<mingo@kernel.org>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <james.morse@arm.com>,
<tanxiaofei@huawei.com>
Subject: Re: [PATCH 4/5] efi: Export Runtime Configuration Interface table to sysfs
Date: Tue, 1 Oct 2019 18:01:47 +0000 [thread overview]
Message-ID: <20191001180133.GA2279@localhost.localdomain> (raw)
In-Reply-To: <8446d19dd197447a88eed580601f3c4c@AUSX13MPC105.AMER.DELL.COM>
On Tue, Oct 01, 2019 at 01:20:46PM +0000, Limonciello, Mario wrote:
[...]
> > > > > > +config EFI_RCI2_TABLE
> > > > > > + bool "EFI Runtime Configuration Interface Table Version 2 Support"
> > > > > > + help
> > > > > > + Displays the content of the Runtime Configuration Interface
> > > > > > + Table version 2 on Dell EMC PowerEdge systems as a binary
> > > > > > + attribute 'rci2' under /sys/firmware/efi/tables directory.
> > > > > > +
> > > > > > + RCI2 table contains BIOS HII in XML format and is used to populate
> > > > > > + BIOS setup page in Dell EMC OpenManage Server Administrator tool.
> > > > > > + The BIOS setup page contains BIOS tokens which can be configured.
> > > > > > +
> > > > > > + Say Y here for Dell EMC PowerEdge systems.
> > > > >
> > > > > A quick Google search tells me these are Intel Xeon.
> > > > > Are arm/arm64/ia64 variants available, too?
> > > > > If not, this should be protected by "depends on x86" ("|| COMPILE_TEST"?).
> > > >
> > > > The code in question is entirely architecture agnostic, and defaults
> > > > to 'n', so I am not convinced this is needed. (It came up in the
> > > > review as well)
> > >
> > > "make oldconfig" still asks me the question on e.g. arm64, where it is
> > > irrelevant, until arm64 variants of the hardware show up.
> > >
> > > So IMHO it should have "depends on X86 || COMPILE_TEST".
> > >
> >
> > Fair enough. I am going to send out a bunch of EFI fixes this week, so
> > I'll accept a patch that makes the change above.
>
> Is it really a problem to just say n?
>
> I think this seems like a needless change that would slow down adoption of
> !x86 if Dell EMC PowerEdge systems did start going that route, especially
> when it comes to distributions that move glacially slow with picking up new
> kernel code.
Hi Ard/Geert,
Any additional thoughts here ?
--
With regards,
Narendra K
next prev parent reply other threads:[~2019-10-01 18:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 15:04 [GIT PULL 0/5] EFI updates for v5.4 Ard Biesheuvel
2019-08-12 15:04 ` [PATCH 1/5] efi: x86: move efi_is_table_address() into arch/x86 Ard Biesheuvel
2019-08-12 15:04 ` [PATCH 2/5] efi/x86: move UV_SYSTAB handling " Ard Biesheuvel
2019-08-12 15:04 ` [PATCH 3/5] efi: ia64: move SAL systab handling out of generic EFI code Ard Biesheuvel
2019-08-12 15:04 ` [PATCH 4/5] efi: Export Runtime Configuration Interface table to sysfs Ard Biesheuvel
2019-10-01 8:51 ` Geert Uytterhoeven
2019-10-01 8:54 ` Ard Biesheuvel
2019-10-01 9:03 ` Geert Uytterhoeven
2019-10-01 9:41 ` Ard Biesheuvel
2019-10-01 13:20 ` Mario.Limonciello
2019-10-01 18:01 ` Narendra.K [this message]
2019-10-01 18:23 ` Geert Uytterhoeven
2019-10-02 10:22 ` Narendra.K
2019-10-02 19:49 ` Narendra.K
2019-08-12 15:04 ` [PATCH 5/5] efi: cper: print AER info of PCIe fatal error Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001180133.GA2279@localhost.localdomain \
--to=narendra.k@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=ard.biesheuvel@linaro.org \
--cc=geert@linux-m68k.org \
--cc=james.morse@arm.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tanxiaofei@huawei.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).