From: Ard Biesheuvel <ardb@kernel.org>
To: linux-efi@vger.kernel.org
Cc: luto@kernel.org, x86@kernel.org, nivedita@alum.mit.edu,
Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH 0/2] efi/libstub/x86: two more tweaks for the EFI stub startup code
Date: Wed, 8 Jan 2020 08:45:00 +0100 [thread overview]
Message-ID: <20200108074502.10960-1-ardb@kernel.org> (raw)
Two final cleanups for the x86 startup code, one that helps the compiler
generate better code, by annotating a helper function with the 'const'
function attribute, and one that fixes the misalignment of the stack in
mixed mode.
There are no known issues regarding entering the 32-bit firmware from the
64-bit kernel with the stack misaligned, and the 32-bit kernel does so all
the time, but it is better to comply with the UEFI spec.
Ard Biesheuvel (2):
efi/libstub/x86: use const attribute for efi_is_64bit()
efi/libstub/x86: use mandatory 16-byte stack alignment in mixed mode
arch/x86/boot/compressed/eboot.c | 14 +++---
arch/x86/boot/compressed/efi_thunk_64.S | 46 ++++++--------------
arch/x86/boot/compressed/head_64.S | 7 ++-
arch/x86/include/asm/efi.h | 2 +-
4 files changed, 23 insertions(+), 46 deletions(-)
--
2.20.1
next reply other threads:[~2020-01-08 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 7:45 Ard Biesheuvel [this message]
2020-01-08 7:45 ` [PATCH 1/2] efi/libstub/x86: use const attribute for efi_is_64bit() Ard Biesheuvel
2020-01-08 15:23 ` Arvind Sankar
2020-01-08 15:25 ` Ard Biesheuvel
2020-01-08 15:25 ` Ard Biesheuvel
2020-01-08 15:27 ` Arvind Sankar
2020-01-08 7:45 ` [PATCH 2/2] efi/libstub/x86: use mandatory 16-byte stack alignment in mixed mode Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108074502.10960-1-ardb@kernel.org \
--to=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=luto@kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).