From: Marco Elver <elver@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com,
x86@kernel.org, linux-efi@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, paulmck@kernel.org
Subject: Re: [PATCH 1/2] kbuild: remove cc-option test of -fno-stack-protector
Date: Wed, 1 Jul 2020 08:01:50 +0200 [thread overview]
Message-ID: <20200701060150.GA1181113@elver.google.com> (raw)
In-Reply-To: <20200626185913.92890-1-masahiroy@kernel.org>
On Sat, Jun 27, 2020 at 03:59AM +0900, Masahiro Yamada wrote:
> Some Makefiles already pass -fno-stack-protector unconditionally.
> For example, arch/arm64/kernel/vdso/Makefile, arch/x86/xen/Makefile.
> No problem report so far about hard-coding this option. So, we can
> assume all supported compilers know -fno-stack-protector.
>
> GCC 4.8 and Clang support this option (https://godbolt.org/z/_HDGzN)
>
> Get rid of cc-option from -fno-stack-protector.
>
> Remove CONFIG_CC_HAS_STACKPROTECTOR_NONE, which should always be 'y'.
>
> Note:
> arch/mips/vdso/Makefile adds -fno-stack-protector twice, first
> unconditionally, and second conditionally. I removed the second one.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Documentation/kbuild/kconfig-language.rst | 4 ++--
> Makefile | 2 +-
> arch/Kconfig | 3 ---
> arch/arm/boot/compressed/Makefile | 3 +--
> arch/mips/vdso/Makefile | 3 +--
> arch/powerpc/kernel/Makefile | 2 +-
> arch/powerpc/platforms/powermac/Makefile | 2 +-
> arch/sparc/vdso/Makefile | 4 ++--
> arch/um/Makefile | 3 +--
> arch/x86/Makefile | 2 +-
> arch/x86/boot/compressed/Makefile | 2 +-
> arch/x86/entry/vdso/Makefile | 4 ++--
> arch/x86/kernel/cpu/Makefile | 3 +--
> arch/x86/lib/Makefile | 2 +-
> arch/x86/mm/Makefile | 7 +++----
> arch/x86/power/Makefile | 3 +--
> arch/x86/purgatory/Makefile | 2 +-
> arch/x86/um/vdso/Makefile | 2 +-
> arch/x86/xen/Makefile | 5 ++---
> drivers/firmware/efi/libstub/Makefile | 2 +-
> drivers/xen/Makefile | 3 +--
> kernel/kcsan/Makefile | 3 +--
Is it possible that this patch drops the KCSAN portion? We have a patch
that is part of a series intended for 5.9 that also removes the
cc-option from -fno-stack-protector, but can't easily be dropped from
the surrounding series.
Please see: https://lkml.kernel.org/r/20200624190236.GA6603@paulmck-ThinkPad-P72
Thanks,
-- Marco
prev parent reply other threads:[~2020-07-01 6:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 18:59 [PATCH 1/2] kbuild: remove cc-option test of -fno-stack-protector Masahiro Yamada
2020-06-26 18:59 ` [PATCH 2/2] kbuild: remove cc-option test of -ffreestanding Masahiro Yamada
2020-06-26 19:58 ` Nick Desaulniers
2020-06-26 20:22 ` Kees Cook
2020-06-27 7:39 ` Ard Biesheuvel
2020-06-26 19:09 ` [PATCH 1/2] kbuild: remove cc-option test of -fno-stack-protector Nick Desaulniers
2020-06-26 20:00 ` Masahiro Yamada
2020-06-26 20:13 ` Kees Cook
2020-06-26 20:13 ` Nick Desaulniers
2020-06-26 20:21 ` Kees Cook
2020-06-26 20:25 ` Nick Desaulniers
2020-06-26 20:37 ` Kees Cook
2020-06-27 11:58 ` Masahiro Yamada
2020-06-29 18:26 ` Nick Desaulniers
2020-06-29 22:39 ` Nick Desaulniers
2020-06-30 18:18 ` Masahiro Yamada
2020-07-01 19:33 ` Masahiro Yamada
2020-06-26 20:18 ` Kees Cook
2020-06-27 7:39 ` Ard Biesheuvel
2020-07-01 6:01 ` Marco Elver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701060150.GA1181113@elver.google.com \
--to=elver@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=paulmck@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).