From: Davidlohr Bueso <dave@stgolabs.net>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Micha?? Miros??aw <mirq-linux@rere.qmqm.pl>,
David Heidelberg <david@ixit.cz>,
Peter Geis <pgwipeout@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Christoph Hellwig <hch@infradead.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
Ion Agorria <AG0RRIA@yahoo.com>,
Svyatoslav Ryhel <clamor95@gmail.com>,
linux-tegra@vger.kernel.org, linux-block@vger.kernel.org,
linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] partitions/efi: Support gpt_sector parameter needed by NVIDIA Tegra devices
Date: Mon, 29 Mar 2021 10:31:51 -0700 [thread overview]
Message-ID: <20210329173151.urs4x36m3bq6txrf@offworld> (raw)
In-Reply-To: <20210327212100.3834-4-digetx@gmail.com>
On Sun, 28 Mar 2021, Dmitry Osipenko wrote:
>All NVIDIA Tegra20..124 Android devices use proprietary bootloader
>which supplies the gpt_sector=<sector> kernel cmdline parameter that
>should be used for looking up the EFI partition table on internal EMMC
>storage. If the kernel cmdline parameter isn't supplied, then the
>partition is expected to be placed around the last but one sector of EMMC.
>
>Apparently this was done in order to hide the PT from a usual userspace
>tools since EFI entry exists only for compatibility with a Linux kernel,
>while a custom proprietary partition table is what is really used by
>these Android devices, thus these tools may corrupt the real PT, making
>device unbootable and very difficult to restore.
>
>Add support for the gpt_sector cmdline parameter which will be used
>for finding EFI entry on internal EMMC storage of NVIDIA Tegra20+ devices.
Since this is proprietary and playing yucky games hiding the pt, why not
just force for the fallback on Nvidia's side and always just use the entry
at the end of the block device? I'm not loving introducing a generic parameter
for an obscure ad-hoc feature.
Thanks,
Davidlohr
next prev parent reply other threads:[~2021-03-29 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 21:20 [PATCH v1 0/3] Support EFI partition on NVIDIA Tegra devices Dmitry Osipenko
2021-03-27 21:20 ` [PATCH v1 1/3] mmc: core: Add raw_boot_mult field to mmc_ext_csd Dmitry Osipenko
2021-03-27 21:20 ` [PATCH v1 2/3] mmc: block: Add mmc_bdev_to_card() helper Dmitry Osipenko
2021-03-27 21:21 ` [PATCH v1 3/3] partitions/efi: Support gpt_sector parameter needed by NVIDIA Tegra devices Dmitry Osipenko
2021-03-29 6:18 ` Christoph Hellwig
2021-03-29 13:07 ` Dmitry Osipenko
2021-03-29 17:31 ` Davidlohr Bueso [this message]
2021-03-29 18:38 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329173151.urs4x36m3bq6txrf@offworld \
--to=dave@stgolabs.net \
--cc=AG0RRIA@yahoo.com \
--cc=adrian.hunter@intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=axboe@kernel.dk \
--cc=clamor95@gmail.com \
--cc=david@ixit.cz \
--cc=digetx@gmail.com \
--cc=hch@infradead.org \
--cc=jonathanh@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pgwipeout@gmail.com \
--cc=rdunlap@infradead.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).