From: Chengguang Xu <cgxu519@mykernel.net>
To: xiang@kernel.org, chao@kernel.org
Cc: Chengguang Xu <cgxu519@mykernel.net>, linux-erofs@lists.ozlabs.org
Subject: [PATCH] erofs: remove unnecessary output in erofs_show_options()
Date: Tue, 19 Nov 2019 19:50:49 +0800 [thread overview]
Message-ID: <20191119115049.3401-1-cgxu519@mykernel.net> (raw)
We have already handled cache_strategy option carefully,
so incorrect setting could not pass option parsing.
Meanwhile, print 'cache_strategy=(unknown)' can cause
failure on remount.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/erofs/super.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 06e721bd1c8c..65c7da996643 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -581,9 +581,6 @@ static int erofs_show_options(struct seq_file *seq, struct dentry *root)
seq_puts(seq, ",cache_strategy=readahead");
} else if (sbi->cache_strategy == EROFS_ZIP_CACHE_READAROUND) {
seq_puts(seq, ",cache_strategy=readaround");
- } else {
- seq_puts(seq, ",cache_strategy=(unknown)");
- DBG_BUGON(1);
}
#endif
return 0;
--
2.20.1
next reply other threads:[~2019-11-19 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 11:50 Chengguang Xu [this message]
2019-11-19 13:02 ` [PATCH] erofs: remove unnecessary output in erofs_show_options() Gao Xiang
2019-11-21 1:13 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119115049.3401-1-cgxu519@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=chao@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).